Paper button styles #2669
Closed
Paper button styles #2669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Woah- this looks amazing ❤️ Awesome job, @rossmoody 😄 Will try to review soon... |
petemill
requested changes
Jun 24, 2019
| border-color: currentColor !important; | ||
|
|
||
| --flat-focus-shadow-color: rgba(255, 69, 48, .4) !important; | ||
| --type-color: #3b3e4f; /* grey800 */ |
There was a problem hiding this comment.
Is this a variable name we're making here? If so please prefix with brave- otherwise we may conflict with chromium (these variable names are global).
Same for default-border.
Anything without a prefix should be something defined in the chromium webui codebase that we want to override.
Anything with a prefix like paper-button- will be something defined in a specific paper (or other) library component that we want to override.
Apologies that there's no docs yet for this.
| @@ -7,73 +7,53 @@ | |||
| /* Refer to: | |||
| * ui/webui/resources/cr_elements/paper_button_style_css.html | |||
| * for styles to override. | |||
| * | |||
There was a problem hiding this comment.
Is there no longer a translation? We're using action-button still, right?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: brave/brave-browser#3633
Fixes: brave/brave-browser#4852
Before
After
Test Plan:
The buttons effected by these style updates live in