Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Global Javascript and Cookie blocking #402

Closed
srirambv opened this issue Jun 22, 2018 · 2 comments · Fixed by brave/brave-core#493
Closed

Remove Global Javascript and Cookie blocking #402

srirambv opened this issue Jun 22, 2018 · 2 comments · Fixed by brave/brave-core#493
Labels
feature/global-settings Settings at browser level independent of shields settings QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@srirambv
Copy link
Contributor

Description

Remove JavaScript and Cookie blocking from global settings as its being managed by Shields.

Additional Information

#226
@srirambv srirambv added the feature/global-settings Settings at browser level independent of shields settings label Jun 22, 2018
@srirambv srirambv added this to the Releasable builds milestone Jun 22, 2018
@srirambv srirambv mentioned this issue Aug 10, 2018
Closed
@rebron rebron changed the title Remove Global Javascprit and Cookie blocking Remove Global Javascript and Cookie blocking Sep 11, 2018
@rebron
Copy link
Collaborator

rebron commented Sep 20, 2018

I think this is issue is meant to remove Chrome's Global Javascript and Cookie blocking in favor of our global shield settings:
#606
#955

bbondy added a commit to brave/brave-core that referenced this issue Sep 25, 2018
@bbondy
Hide settings which do not apply to Brave
e4c003b 
3rd party cookies is per site and block by default in Brave

We use our own ad block, not Google's adblock-ish, but not really
adblock.

Fix brave/brave-browser#402
Fix brave/brave-browser#1119
@bbondy bbondy added the QA/Yes label Sep 25, 2018
@bbondy bbondy mentioned this issue Sep 25, 2018
Merged
11 tasks
@btlechowski
Copy link

btlechowski commented Sep 27, 2018 •
edited by srirambv
Loading

Verification passes on

Brave 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta (64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Windows 7
  • javascript toggle is deleted from chrome://settings/content/javascript
  • blocked third-party cookies toggle is deleted from chrome://settings/content/cookies

Verified passed with

Brave 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta(64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Mac OS X
  • javascript toggle is deleted from chrome://settings/content/javascript
  • blocked third-party cookies toggle is deleted from chrome://settings/content/cookies

Verified passed with

Brave 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta(64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Linux
  • javascript toggle is deleted from chrome://settings/content/javascript
  • blocked third-party cookies toggle is deleted from chrome://settings/content/cookies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/global-settings Settings at browser level independent of shields settings QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Hide settings which do not apply to Brave brave/brave-core
5 participants
@bbondy @rebron @srirambv @LaurenWags @btlechowski