Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global Shields Settings restyle #606

Closed
jumde opened this issue Jul 19, 2018 · 6 comments
Closed

Global Shields Settings restyle #606

jumde opened this issue Jul 19, 2018 · 6 comments
Assignees
@petemill @rebron
Labels
closed/invalid closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. design A design change, especially one which needs input from the design team feature/global-settings Settings at browser level independent of shields settings feature/shields The overall Shields feature in Brave.

Comments

@jumde
Copy link
Contributor

jumde commented Jul 19, 2018

Shield settings are available per site as of now.
@bbondy bbondy added this to the Releasable builds milestone Jul 26, 2018
@jumde
Copy link
Contributor Author

jumde commented Aug 16, 2018

This is available in browser-laptop

@rebron
Copy link
Collaborator

rebron commented Sep 7, 2018

global-shield-settings

See #955 for placement

@rebron
Copy link
Collaborator

rebron commented Sep 7, 2018

site-permissions

For Site permissions, moving parts of content settings into this section.

@rebron
Copy link
Collaborator

rebron commented Sep 7, 2018

allow-block-list

Allow and Block list.

@rebron rebron mentioned this issue Sep 20, 2018
Closed
@bbondy bbondy changed the title Global Shield Settings Global Shield Settings front end Sep 22, 2018
@bbondy bbondy modified the milestones: Releasable builds 0.55.x, 1.0 Sep 26, 2018
@bbondy
Copy link
Member

bbondy commented Sep 26, 2018

Moved to 1.0 because we have the functionality for global shields available here with existing looking settings UI: #1288

I think we could probably move this even past 1.0 if needed because of timing.

@bbondy bbondy mentioned this issue Sep 26, 2018
Closed
@bbondy bbondy modified the milestones: 1.0 (0.56.x), Releasable builds 0.55.x Sep 28, 2018
@rebron rebron mentioned this issue Sep 30, 2018
Closed
@tildelowengrimm tildelowengrimm added the feature/shields The overall Shields feature in Brave. label Oct 11, 2018
@bbondy bbondy modified the milestones: 1.0, 1.x Backlog Oct 30, 2018
@bsclifton bsclifton changed the title Global Shield Settings front end Global Shields Settings restyle Oct 30, 2018
@bsclifton bsclifton mentioned this issue Oct 30, 2018
Closed
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@rebron rebron added closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. closed/invalid and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Apr 16, 2019
@rebron
Copy link
Collaborator

rebron commented Apr 16, 2019

Closing in favor of newer design.

@rebron rebron closed this as completed Apr 16, 2019
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Jun 3, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petemill petemill

@rebron rebron

Labels
closed/invalid closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. design A design change, especially one which needs input from the design team feature/global-settings Settings at browser level independent of shields settings feature/shields The overall Shields feature in Brave.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@tildelowengrimm @petemill @bbondy @jumde @bsclifton @rebron @NejcZdovc @rossmoody