Hide settings which do not apply to Brave #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3rd party cookies is per site and block by default in Brave We use our own ad block, not Google's adblock-ish, but not really adblock. Fix brave/brave-browser#402 Fix brave/brave-browser#1119
darkdh
reviewed
Sep 25, 2018
| </paper-icon-button-light> | ||
| </div> | ||
| </template> | ||
| +</if> |
There was a problem hiding this comment.
can we merge the /if and if google_chrome here?
There was a problem hiding this comment.
Was intentionally separate here because then if something is added in between it won't be hidden by the patch
|
do we need to block access to ad page when user type |
|
In order to achieve above comment, we have to modify |
|
I don't think it's a big deal, I just don't want it to show up from browsing settings. |
darkdh
added a commit
that referenced
this pull request
Sep 25, 2018
Hide settings which do not apply to Brave
bbondy
commented
Sep 25, 2018
|
|
||
| // TODO(tommycli): Find a way to refactor these repetitive category | ||
| // routes. | ||
| +<if expr="_google_chrome"> |
There was a problem hiding this comment.
Shouldn't this have a comment indicator before it? The other things in this file do.
|
Added label merged/0.55.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3rd party cookies is per site and block by default in Brave
We use our own ad block, not Google's adblock-ish, but not really
adblock.
Fix brave/brave-browser#402
Fix brave/brave-browser#1119
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
a. ads
chrome://settings/contentchrome://settings/content/adschrome://settingsb. javascript
chrome://settings/content/javascriptc. cookie
chrome://settings/content/cookiesReviewer Checklist: