Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excluded publisher included back in #3551

Closed
NejcZdovc opened this issue Mar 2, 2019 · 3 comments · Fixed by brave/brave-core#1823
Closed

Excluded publisher included back in #3551

NejcZdovc opened this issue Mar 2, 2019 · 3 comments · Fixed by brave/brave-core#1823

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Mar 2, 2019

Description

Steps to Reproduce

  1. clean profile / enable rewards
  2. visit a site and add it to ac table
  3. make sure that you see it the panel
  4. visit another site (don't stay on it for min visit time, if needed adjust min visit time to a minute)
  5. exclude site
  6. make sure that you see 1 excluded site in settings page
  7. close panel and open it again

Actual result:

site is included again

Expected result:

site should remain excluded

Reproduces how often:

100%

Brave version (brave://version info)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

This only happens for sites that are not in ac table

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Mar 7, 2019

The issue is reproduced on Linux mint - 0.61.48

exclude issue1

exclude issue

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Mar 19, 2019

Reproducible on 0.63.14. STR is a bit different

  1. Clean profile 0.63.14
  2. Enable rewards through BR panel
  3. Open Twitch.tv
  4. Open few twitch videos of same publisher in multiple tabs
  5. Verify pubs added to a-c table
  6. Toggle the include button to OFF for one of the twitch video ( step 4 - videos playing in all tabs should get excluded as all videos belongs to same publisher)
  7. Verify the pub from step 6 got excluded from a-c table
  8. Open another new video of same pubs, stay on page for ~20 sec

Actual: In BR panel, the included switch is in ON state though it's of same pubs where it was excluded in step 6

@btlechowski
Copy link

btlechowski commented Apr 4, 2019

Verification passed on

Brave 0.63.30 Chromium: 73.0.3683.75 (Official Build) beta (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Windows 10 OS Build 17134.523

Used test plan from brave/brave-core#1823

Verified passed with

Brave 0.63.31 Chromium: 73.0.3683.75 (Official Build) beta(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Mac OS X

Verification passed on

Brave 0.63.31 Chromium: 73.0.3683.75 (Official Build) beta(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Ubuntu 18.04 LTS

Used test plan from brave/brave-core#1823

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment