Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot switch off Include in Auto-contribute in BR panel #3476

Closed
GeetaSarvadnya opened this issue Feb 25, 2019 · 4 comments · Fixed by brave/brave-core#1782
Closed

Cannot switch off Include in Auto-contribute in BR panel #3476

GeetaSarvadnya opened this issue Feb 25, 2019 · 4 comments · Fixed by brave/brave-core#1782

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Feb 25, 2019

Description

Cannot switch off Include in Auto-contribute in BR panel

Steps to Reproduce

  1. Open brave Dev or Beta
  2. Enable Rewards
  3. Open any website
  4. Open BR panel for the website
  5. Try to turn off Include in Auto-contribute

Actual result:

Cannot switch off Include in Auto-contribute in BR panel

3476

Expected result:

Should be able to turn off Include in Auto-contribute

Reproduces how often:

Always

Brave version (brave://version info)

Brave 0.61.36 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Windows 10 OS Build 17134.523

Reproducible on current release: No

  • Does it reproduce on brave-browser dev/beta builds? Yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional Information

The issue is reported by the community
https://community.brave.com/t/cannot-switch-off-include-in-auto-contribute-anymore/45874

@brave/legacy_qa

@NejcZdovc NejcZdovc self-assigned this Feb 25, 2019
@NejcZdovc NejcZdovc added the priority/P2 A bad problem. We might uplift this to the next planned release. label Feb 25, 2019
@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Feb 25, 2019

Found a few issues on further investigation: This issue is tracked in #3480

  1. Clean profile 0.61.36
  2. Enable Rewards
  3. Add DDG to a-c table
  4. Open BR panel for DDG
  5. Click on Include in Auto-Contribute switch multiple times
    The site which is added in a-c table gets deleted, and below message is displayed
    Total number of sites you excluded from Auto-Contribute: 34(Restore All)
  6. At one point, switch gets turned off in BR panel for DDG
  7. Click on Include in Auto-Contribute switch multiple times
    The site which is added in a-c table gets deleted, and below message is displayed
    Total number of sites you excluded from Auto-Contribute: 4294967286 (Restore All)

Please find the GIF file below.
issue with a-c table exclude sites

@LaurenWags
Copy link
Member

Reproduced original issue from description and #3476 (comment) with build below.

Brave 0.61.45 Chromium: 73.0.3683.39 (Official Build) beta(64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Mac OS X

@NejcZdovc
Copy link
Contributor

@LaurenWags this is still in 0.63, it's waiting for uplift

@btlechowski
Copy link

btlechowski commented Mar 6, 2019

Verification passed on

Brave 0.61.47 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Windows 7 Service Pack 1 Build 7601.24312

Used test plan from the description.
Encountered #3551 while testing.

Verification passed on

Brave 0.61.48 Chromium: 73.0.3683.56 (Official Build) beta (64-bit)
Revision 303af44e2f2948869279f120021c778855d76ead-refs/branch-heads/3683@{#653}
OS Linux

Verified passed with

Brave 0.61.48 Chromium: 73.0.3683.56 (Official Build) beta(64-bit)
Revision 303af44e2f2948869279f120021c778855d76ead-refs/branch-heads/3683@{#653}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants