Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect exclude count displayed in a-c table #3480

Closed
GeetaSarvadnya opened this issue Feb 25, 2019 · 1 comment · Fixed by brave/brave-core#1782
Closed

Incorrect exclude count displayed in a-c table #3480

GeetaSarvadnya opened this issue Feb 25, 2019 · 1 comment · Fixed by brave/brave-core#1782

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Feb 25, 2019

Description

Found while testing #3476
Incorrect exclude count displayed in a-c table

Steps to Reproduce

  1. Clean profile 0.61.36
  2. Enable rewards
  3. Open DDG and add it to a-c table
  4. Click on Include in Auto-Contribute switch multiple times
  5. Observe that exclude count shows up incorrect count
  6. Click on Include in Auto-Contribute switch multiple times when the switch is turned off
  7. Observe that exclude count shows up incorrect count

Actual result:

The message displayed after step 5:
Total number of sites you excluded from Auto-Contribute: 34(Restore All)

The message displayed after step 7:
Total number of sites you excluded from Auto-Contribute: 4294967286 (Restore All)

issue with a-c table exclude sites

Expected result:

exclude count should be displayed correctly

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.61.36 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Windows 10 OS Build 17134.523

Reproducible on current release: No

  • Does it reproduce on brave-browser dev/beta builds? Beta

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional Information

@brave/legacy_qa

@btlechowski
Copy link

btlechowski commented Mar 6, 2019

Verification passed on

Brave 0.61.47 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Windows 7 Service Pack 1 Build 7601.24312

Used test plan from brave/brave-core#1782
Used test plan from the description.

Including and excluding sites through Brave Panel works without problems.
There is still a problem when including and excluding sites through brave://rewards/. Logged #3610

Verification passed on

Brave 0.61.48 Chromium: 73.0.3683.56 (Official Build) beta (64-bit)
Revision 303af44e2f2948869279f120021c778855d76ead-refs/branch-heads/3683@{#653}
OS Linux

Verification PASSED on macOS 10.14.3 x64 using the following build:

Brave 0.61.48 Chromium: 73.0.3683.56 (Official Build) beta(64-bit)
Revision 303af44e2f2948869279f120021c778855d76ead-refs/branch-heads/3683@{#653}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants