Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes publisher info getting lost on publishers not in activity table #1823

Merged
merged 1 commit into from
Mar 4, 2019

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Mar 2, 2019

Resolves brave/brave-browser#3551

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Verified that all lint errors/warnings are resolved (npm run lint)
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  • clean profile
  • enable rewards
  • visit a site and add it to ac table
  • make sure that you see it the panel
  • visit another site (don't stay on it for min visit time, if needed adjust min visit time to a minute)
  • exclude site
  • make sure that you see 1 excluded site in settings page
  • close panel and open it again
  • make sure that exclude status is preserved

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

Copy link
Contributor

@jasonrsadler jasonrsadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ for this PR.

Found a possible issue @NejcZdovc, When a publisher is already added to the ac-list and you change the "minimum required viewing time" to something higher, the site that was on the list goes away (if it hasn't met that new criteria). Is this what we want?

@NejcZdovc
Copy link
Contributor Author

@jasonrsadler yes what is your setting should be reflected in the ac. So if you have min visit time for 1min it should only show publishers that have at least 1min visit time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Excluded publisher included back in
2 participants