Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTP quick actions (Customize, Settings, etc) are not placed on NTP SI appropriately when the clock is removed from view - Follow up to 28736 #29246

Closed
LaurenWags opened this issue Mar 22, 2023 · 2 comments · Fixed by brave/brave-core#17764
Assignees
Labels
feature/new-tab OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes release-notes/include

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Mar 22, 2023

Description

Found while testing #28736.

If you remove the clock from view on NTP, when an NTP SI is displayed the actions normally in the lower right corner (Customize, Bookmarks, etc) are now displayed about halfway up the NTP.

Furthermore, if the widgets aren't displayed either, these actions are "behind" the clickable NTP SI area, so clicking on them results in you visiting the area the URL is set to.

Steps to Reproduce

  1. Remove all items from view on NTP
  2. Navigate to NTP SI if not already on one
  3. See Customize, Settings, etc about halfway up the page
  4. Try to click on Customize to fix clock view, get directed to clickable area's URL
  5. If you go to regular NTP, Customize, etc display appropriately
  6. Re-enable cards/widgets only (not clock)
  7. Nav to NTP SI again
  8. Customize, etc are still improperly placed.

Actual result:

Nothing on NTP SI Cards/Widgets only Clock only Regular NTP
1 2 3 4

Expected result:

Customize, etc should always be placed appropriately on NTP SI even if elements like clock are not displayed

This is from 1.49.120:

Screen Shot 2023-03-22 at 11 38 54 AM

Reproduces how often:

easily

Brave version (brave://version info)

Brave | 1.49.128 Chromium: 111.0.5563.110 (Official Build) (x86_64)
-- | --
Revision | 3da375c9e9e5ad9b556af5df708a6e6c01d8cfb1-refs/branch-heads/5563@{#1202}
OS | macOS Version 12.6.3 (Build 21G419)

Version/Channel Information:

  • Can you reproduce this issue with the current release? 1.49.128 yes, 1.49.120 n/a
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? unsure, probably yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @rebron @brave/qa-team

@kjozwiak
Copy link
Member

The above requires 1.50.107 or higher for 1.50.x verification 👍

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 30, 2023
@LaurenWags
Copy link
Member Author

LaurenWags commented Mar 30, 2023

Verified with

Brave | 1.50.110 Chromium: 112.0.5615.49 (Official Build) (x86_64)
-- | --
Revision | bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS | macOS Version 12.6.4 (Build 21G526)

Verified steps from #29246 (comment).
Confirmed Customize, Settings, etc are properly placed when there are no widgets displayed on NTP SI.

All Widgets Shown No Widgets Shown
1 2

Confirmed Customize, Settings, etc are properly placed when one widget at a time is shown on NTP SI.

Example Example Example Example
1 2 3 4

Confirmed Customize, Settings, etc are properly placed when different combinations of widgets are shown on NTP SI (not all combinations pictured, just a few).

Example Example Example Example
5 6 7 8

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/new-tab OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes release-notes/include
Projects
None yet
5 participants