-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clickable centered block to support new tab page sponsored images #28736
Labels
feature/new-tab
OS/Desktop
priority/P2
A bad problem. We might uplift this to the next planned release.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-All-Platforms
QA/Yes
release-notes/include
Milestone
Comments
rebron
added
priority/P2
A bad problem. We might uplift this to the next planned release.
QA/Yes
release-notes/include
labels
Feb 24, 2023
25 tasks
MadhaviSeelam
added
the
QA/In-Progress
Indicates that QA is currently in progress for that particular issue
label
Mar 15, 2023
Verification
Case 1: New Install
Confirmed able to hover and click centered block with widgets on the right,
|
MadhaviSeelam
added
QA Pass-Win64
and removed
QA/In-Progress
Indicates that QA is currently in progress for that particular issue
labels
Mar 15, 2023
Verification
|
Brave | 1.50.92 Chromium: 111.0.5563.64 (Official Build) beta (x86_64) |
---|---|
Revision | c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995} |
OS | macOS Version 11.7.4 (Build 20G1120) |
Case 1: New install - PASSED
- installed
1.50.92
- launched Brave
- opened a new-tab page
- added few top sites to NTP
- visited a new tab page to load a sponsored image
- click box/clickable area is shown to new tab page sponsored images in between the NTP grid and the widgets on the right
- hovered and clicked onto the center of the sponsored image, between top sites and widgets and above Brave News.
- it redirected to the proper destination url (similar to clicking the bottom left call out) -
https://search.brave.com/?brave-creative-id=ee855d01-3203-4a07-963c-5b59fd2b63be&source=sponsoredimage20230317
- confirmed destination URL is shown bottom left -
https://search.brave.com/?brave-creative-id=ee855d01-3203-4a07-963c-5b59fd2b63be&source=sponsoredimage20230317
- clicked anywhere in the clickable area to redirect to destination URL -
https://search.brave.com/?brave-creative-id=ee855d01-3203-4a07-963c-5b59fd2b63be&source=sponsoredimage20230317
- If widgets are showing and the screen is in one column mode, we don't add the clickbox
- If widgets are not visible, the clickbox/clickable area is shown
- clicked on the bottom left link or image to confirm it's working as expected
- clickable centered block is not shown on non NTPSI pages
default spaces |
no widgets |
no topsites |
no widgets nor topsites |
---|---|---|---|
Case 2: Upgrade - PASSED
- installed 1.49.120
- launched Brave
- opened a NTP SI page
- added a few top sites
- closed the browser
- renamed the profile to
Brave-Beta
- installed
1.50.92
- relaunched Brave
Confirmed functionality worked as expected as in Case 1
Verification passed on
Brave | 1.50.93 Chromium: 111.0.5563.64 (Official Build) beta (64-bit) |
---|---|
Revision | c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995} |
OS | Ubuntu 18.04 LTS |
Case 1: New install - PASSED
- installed
1.50.x
- launched Brave
- opened a new-tab page
- added few top sites to NTP
- visited a new tab page to load a sponsored image
- click box/clickable area is shown to new tab page sponsored images in between the NTP grid and the widgets on the right
- hovered and clicked onto the center of the sponsored image, between top sites and widgets and above Brave News.
- it redirected to the proper destination url (similar to clicking the bottom left call out)
- confirmed destination URL is shown bottom left
- clicked anywhere in the clickable area to redirect to destination URL
- If widgets are showing and the screen is in one column mode, we don't add the clickbox
- If widgets are not visible, the clickbox/clickable area is shown
- clicked on the bottom left link or image to confirm it's working as expected
- clickable centered block is not shown on non NTPSI pages
Case 2: Upgrade - PASSED
Removing |
The above requires |
This was referenced Mar 22, 2023
Verification passed on
Case 1: New install -
|
Verified with
Encountered #29246 while testing. Case 1: New install -
|
Wide view | Narrow (single column) view |
---|---|
Videos for verifications were made but were too big to upload to GH, available on the drive if needed.
Case 2: Upgrade - PASSED
Verification
|
Brave | 1.49.128 Chromium: 111.0.5563.110 (Official Build) (64-bit) |
---|---|
Revision | 3da375c9e9e5ad9b556af5df708a6e6c01d8cfb1-refs/branch-heads/5563@{#1202} |
OS | Windows 10 Version 22H2 (Build 19045.2728) |
NOTE: pressed for time on the 1.49.x maintenance release, didn't include videos
Case 1: New install - PASSED
- installed
1.49.128
- launched Brave
- opened a new-tab page
- added few top sites to NTP
- visited a new tab page to load a sponsored image
- click box/clickable area is shown to new tab page sponsored images in between the NTP grid and the widgets on the right
- hovered and clicked onto the center of the sponsored image, between top sites and widgets and above Brave News.
- it redirected to the proper destination url (similar to clicking the bottom left call out) -
https://search.brave.com/?brave-creative-id=ee855d01-3203-4a07-963c-5b59fd2b63be&source=sponsoredimage20230317
- confirmed destination URL is shown bottom left -
https://search.brave.com/?brave-creative-id=ee855d01-3203-4a07-963c-5b59fd2b63be&source=sponsoredimage20230317
- clicked anywhere in the clickable area to redirect to destination URL -
https://search.brave.com/?brave-creative-id=ee855d01-3203-4a07-963c-5b59fd2b63be&source=sponsoredimage20230317
- If widgets are showing and the screen is in one column mode, we don't add the clickbox
- If widgets are not visible, the clickbox/clickable area is shown
- clicked on the bottom left link or image to confirm it's working as expected
- clickable centered block is not shown on non NTPSI pages
default spaces |
no widgets |
no topsites |
no widgets nor topsites |
---|---|---|---|
Case 2: Upgrade - PASSED
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature/new-tab
OS/Desktop
priority/P2
A bad problem. We might uplift this to the next planned release.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-All-Platforms
QA/Yes
release-notes/include
Description
New tab page sponsored images contain visual interest that's centered on the user's screen. Oftentimes users will want to clickthrough on that item instead of clicking through on the bottom left call out.
We need a clickable centered block to allow users to clickthrough on sponsored images. The centered block will be removed altogether when the viewport is minimized.
Clicking through the center block should change the mouseover/hover icon to show that the center is clickable. Further, the clickable space should maintain ample space for the widgets to reduce any mis-clicks.
Steps for new feature:
Expected result:
Reproduces how often:
n/a
Brave version (brave://version info)
Targeting 1.49.x
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
The text was updated successfully, but these errors were encountered: