Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clickable sponsored image to advert URL #16620

Closed
rebron opened this issue Jun 25, 2021 · 2 comments
Closed

Clickable sponsored image to advert URL #16620

rebron opened this issue Jun 25, 2021 · 2 comments
Labels

Comments

@rebron
Copy link
Collaborator

rebron commented Jun 25, 2021

Description

Follow-up issue to #13190.
Allow users to click directly on the sponsored image to the advertisers URL within a predefined click area.

Dependency on #12700

Design

Frame 40

Expected Result

  1. Open Brave and view a New Tab Sponsored image.
  2. Area under top sites, the middle of the page up until the widget section, should all be clickable. When the cursor is over the image and the click-through can execute, the icon of the cursor should change to the pointer and the click-URL should be displayed in the bottom left of the NTP.
  3. When users clickthrough they should be directed to the advertisers URL

Brave version (brave://version info)

n/a

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the nightly channel? n/a

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

May need to address responsive issue first: #12700

Assets

Figma: https://www.figma.com/file/FMuS3IZbzqzQTyRHz42Oix/?node-id=1367%3A47295

@rebron rebron added feature/new-tab priority/P3 The next thing for us to work on. It'll ride the trains. labels Jun 25, 2021
@rebron rebron added the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Jun 25, 2021
@karenkliu
Copy link

Designs added!

@karenkliu karenkliu removed the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Jul 14, 2021
@karenkliu karenkliu assigned rebron and unassigned karenkliu Jul 14, 2021
@rebron rebron removed their assignment Jul 20, 2021
@rebron rebron added closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. and removed priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude labels Mar 28, 2023
@rebron
Copy link
Collaborator Author

rebron commented Mar 28, 2023

Closing as dupe of #28736

@rebron rebron closed this as completed Mar 28, 2023
@rebron rebron added closed/duplicate Issue has already been reported and removed closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. labels Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants