Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uplift] [1.49] NTPSI Clickbox #17677

Merged
merged 2 commits into from
Mar 22, 2023
Merged

[Uplift] [1.49] NTPSI Clickbox #17677

merged 2 commits into from
Mar 22, 2023

Conversation

fallaciousreasoning
Copy link
Contributor

Uplift #17356 which resolves brave/brave-browser#28736

@fallaciousreasoning fallaciousreasoning requested a review from a team as a code owner March 20, 2023 19:14
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Mar 20, 2023
@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@kjozwiak kjozwiak added this to the 1.49.x - Release #3 milestone Mar 22, 2023
@bsclifton bsclifton force-pushed the ntpsi-clickbox-1.49 branch from ac7b169 to 4eddd60 Compare March 22, 2023 05:57
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.49.x approved 👍 QA has verified the PR on Nightly as per brave/brave-browser#28736 (comment) & brave/brave-browser#28736 (comment).

@kjozwiak kjozwiak merged commit 3304f9c into 1.49.x Mar 22, 2023
@kjozwiak kjozwiak deleted the ntpsi-clickbox-1.49 branch March 22, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants