Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix placement of image attribution & customize button when showing the NTP SI Clickbox #17764

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

fallaciousreasoning
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning commented Mar 26, 2023

Resolves brave/brave-browser#29246

@LaurenWags looking into this I noticed that removing the Stats widget also looks a little weird (it pushes the other widgets lower). I was wondering if this is intentional though, as it looks like it's been around a bit longer than this issue.

Screenshot, with Clock:
image

Screenshot, without Clock:
image

note: The red borders are only present in the screenshots.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See issue

@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Mar 26, 2023
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@simonhong
Copy link
Member

Whenever I test css properties, I fall in love with dev tools :)
image

@LaurenWags
Copy link
Member

LaurenWags commented Mar 27, 2023

Verified with

Brave | 1.51.65 Chromium: 112.0.5615.39 (Official Build) nightly (x86_64)
-- | --
Revision | a0e7b9718a92bcd1cf33b7c95316caff3fc20714-refs/branch-heads/5615@{#753}
OS | macOS Version 12.6.3 (Build 21G419)

Verified steps from brave/brave-browser#29246 (comment).
Confirmed Customize, Settings, etc are properly placed when there are no widgets displayed on NTP SI.

All Widgets Shown No Widgets Shown
1 2

Confirmed Customize, Settings, etc are properly placed when one widget at a time is shown on NTP SI.

Example Example Example Example
Screen Shot 2023-03-27 at 2 47 42 PM Screen Shot 2023-03-27 at 2 48 00 PM Screen Shot 2023-03-27 at 2 48 16 PM Screen Shot 2023-03-27 at 2 48 32 PM

Confirmed Customize, Settings, etc are properly placed when different combinations of widgets are shown on NTP SI (not all combinations pictured, just a few).

Example Example Example Example
Screen Shot 2023-03-27 at 2 54 04 PM Screen Shot 2023-03-27 at 2 54 22 PM Screen Shot 2023-03-27 at 2 54 43 PM Screen Shot 2023-03-27 at 2 55 04 PM

kjozwiak pushed a commit that referenced this pull request Mar 27, 2023
…on when showing the NTP SI Clickbox (#17766)

Fix placement of image attribution & customize button when showing the NTP SI Clickbox (#17764)

Change row span when there are fewer rows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
4 participants