Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display wallet icon when viewing brave://wallet/swap #29221

Closed
jamesmudgett opened this issue Mar 22, 2023 · 2 comments · Fixed by brave/brave-core#17947 or brave/brave-core#18024
Closed
Assignees
Labels

Comments

@jamesmudgett
Copy link

jamesmudgett commented Mar 22, 2023

Make sure that the wallet icon is visible in the URL bar when visiting brave://wallet/swap, the interaction with the wallet from the url bar should be similar to that of a DApp. When an order must be confirmed the wallet confirmation panel should be displayed. If a user needs to get to pending transactions that have been dismissed they can do that easily by tapping on the wallet icon (which would also display the pending confirmation notification badge).

@kjozwiak
Copy link
Member

The above requires 1.50.120 or higher for 1.50.x verification 👍

@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.50.120 x64 build

  • Verified able to visit brave://wallet/swap and is immediately connected to the wallet network
  • Verified wallet icon is always shown on visiting brave://wallet/swap
  • Verified selecting Swap from token details page or from action button loads a new tab and loads brave://wallet/swap
  • Verified if there is already an opened swap page, focus is set to it rather than opening a new tab
  • Encountered #29681, #29682, #29811 & #29812
Oppo Reno 5(Android 13) Lenovo Tab (Android 12)
17947-ARM.mp4
17947-Tab.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment