Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap option on Buy/Send/Swap button only shows up when you select a token on Swap screen #29682

Closed
srirambv opened this issue Apr 13, 2023 · 2 comments · Fixed by brave/brave-core#18343
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

srirambv commented Apr 13, 2023

Description

Swap option on Buy/Send/Swap button only shows up when you select a token on Swap screen

Steps to reproduce

  1. Install 1.52.40 clean install and create wallet
  2. Click on Buy/Send/Swap button
  3. Only Buy and Send options are shown
  4. Open a new tab and load brave://wallet/swap
  5. Select a Swap from and Swap to token
  6. Go back to wallet and select Buy/Send/Swap token, now Swap is shown

Actual result

Missing.Swap.button.mp4

Expected result

Should always show the Swap button

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? NA
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 13

Brave version

1.52.40

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc; @vadimstruts @SergeyZhukovsky @jamesmudgett

@kjozwiak
Copy link
Member

The above requires 1.52.95 or higher for 1.52.x verification 👍

@srirambv
Copy link
Contributor Author

Verification passed on Oppo Reno 5 with Android 13 running 1.52.113 x64 build

  • Verified steps from issue description
  • Verified Swap option is shown on the Buy/Send/Swap button on a clean install
  • Verified selecting Swap from wallet screen sets Ethereum as the default network irrespective of which network is set as default in wallet panel screen.
29682.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/exclude
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants