Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always show buy send swap action #18343

Merged
merged 2 commits into from
May 4, 2023
Merged

Conversation

Pavneet-Sing
Copy link

@Pavneet-Sing Pavneet-Sing commented May 3, 2023

Resolves brave/brave-browser#29695
Resolves brave/brave-browser#29682

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • BSS actions should always be shown on primary tabs via floating button after login
  • BSS action screens should show ETH as the selected network
eth-BSS.webm

@Pavneet-Sing Pavneet-Sing added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x86 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 labels May 3, 2023
@Pavneet-Sing Pavneet-Sing self-assigned this May 3, 2023
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@Pavneet-Sing Pavneet-Sing merged commit 262c1f5 into master May 4, 2023
@Pavneet-Sing Pavneet-Sing deleted the always-show-buy-send-swap-action branch May 4, 2023 06:43
@github-actions github-actions bot added this to the 1.53.x - Nightly milestone May 4, 2023
Pavneet-Sing pushed a commit that referenced this pull request May 4, 2023
@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 13 running 1.53.26 x64 Nightly build

  • Verified steps from PR
  • Verified BSS button is shown on all 3 tabs of wallet (Portfolio/NFT/Accounts)
  • Verified selecting BSS sets Ethereum account as active irrespective of what network is set in portfolio/NFT
18343.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 feature/web3/wallet unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
3 participants