Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with pending wallet confirmations closing wallet from full view when "Cancel" is tapped. #29222

Closed
jamesmudgett opened this issue Mar 22, 2023 · 3 comments · Fixed by brave/brave-core#17947 or brave/brave-core#18024
Closed

Fix issue with pending wallet confirmations closing wallet from full view when "Cancel" is tapped. #29222

jamesmudgett opened this issue Mar 22, 2023 · 3 comments · Fixed by brave/brave-core#17947 or brave/brave-core#18024
Assignees
@vadimstruts
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Milestone
1.50.x - Release #4

Comments

@jamesmudgett
Copy link

jamesmudgett commented Mar 22, 2023 •
edited
Loading

Canceling swap confirmations currently only closes the wallet and doesn’t cancel the transaction, so it appears that the confirmations never go away (the notification badge doesn’t go away and I can continue to get to confirmations that I’ve already canceled). This just needs to be tested by my guess is that because these confirmations are opening in the panel they’re also closing the wallet panel which suggests that there’s some tight coupling between wallet confirmations and expecting the wallet panel UI to be present in the URL bar.
@jamesmudgett jamesmudgett added feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. labels Mar 22, 2023
@vadimstruts vadimstruts mentioned this issue Apr 6, 2023
Merged
25 tasks
@kjozwiak
Copy link
Member

Closing as this was fixed via brave/brave-core#17947 but wasn't closed automatically due to Resolve being used incorrectly via brave/brave-core#17947 (comment).

@kjozwiak kjozwiak added this to the 1.52.x - Nightly milestone Apr 12, 2023
This was referenced Apr 12, 2023
Merged
Merged
@kjozwiak
Copy link
Member

The above requires 1.50.120 or higher for 1.50.x verification 👍

@srirambv
Copy link
Contributor

Verified as part of #29221 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vadimstruts vadimstruts

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.50.x - Release #4
6 participants
@jamesmudgett @kjozwiak @SergeyZhukovsky @srirambv @brave-builds @vadimstruts