Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable first run dialog on Windows #21464

Closed
simonhong opened this issue Mar 3, 2022 · 3 comments · Fixed by brave/brave-core#12482
Closed

Enable first run dialog on Windows #21464

simonhong opened this issue Mar 3, 2022 · 3 comments · Fixed by brave/brave-core#12482
Assignees
Labels
onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop OS/Windows priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/include

Comments

@simonhong
Copy link
Member

simonhong commented Mar 3, 2022

First run dialog is launched on macOS and linux (see #12679)
We want to launch it on Windows also.

@simonhong simonhong self-assigned this Mar 3, 2022
@rebron rebron added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include onboarding Front-end related to helping a new user learn about features within the browser. labels Mar 3, 2022
simonhong added a commit to brave/brave-core that referenced this issue Mar 8, 2022
fix brave/brave-browser#21464
Enabled first run dialog on Windows.
@simonhong simonhong added this to the 1.38.x - Nightly milestone Mar 14, 2022
muliswilliam pushed a commit to brave/brave-core that referenced this issue Mar 16, 2022
fix brave/brave-browser#21464
Enabled first run dialog on Windows.
simonhong added a commit to brave/brave-core that referenced this issue Mar 22, 2022
fix brave/brave-browser#21464
Enabled first run dialog on Windows.
@MadhaviSeelam
Copy link

Brave 1.38.71 Chromium: 100.0.4896.46 (Official Build) beta (64-bit)
Revision 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS Windows 11 Version 21H2 (Build 22000.556)

Clean Install 1.38.x
Launch Brave
Verified FirstRun dialog is displayed

First run dialog on windows

Note: There was a design change so dialog design will not match to mockup in this story. There is a follow up and tested UI and functionality as part of #21694

@kjozwiak
Copy link
Member

kjozwiak commented Apr 4, 2022

We'll need to re-test this via 1.37.x as we're uplifting it into the 1.37.x maintenance release via brave/brave-core#12692. The above will require 1.37.111 or higher for verification using 1.37.x.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 12, 2022

Verification PASSED on

Brave | 1.37.113 Chromium: 100.0.4896.88 (Official Build) (64-bit)
-- | --
Revision | 4450653bfa91182e85723d8f1dee64dd6ce40ed4-refs/branch-heads/4896@{#1086}
OS | Windows 10 Version 21H2 (Build 19044.1586)

Clean profile

OS light theme OS dark theme
image image
  • Confirmed click on Set Brave as default button in first-run dialog set the brave as the default browser and Make Default is removed from the brave://settings/getStarted
  • Confirmed click on the Maybe later button in the first-run dialog doesn't set the brave as the default browser and the Make Default option is shown in the brave://settings/getStarted
  • Confirmed that the user can set the brave as default browser by clicking on the Make Default option is shown in the brave://settings/getStarted
  • Order of the buttons is not as per the mockup (@MadhaviSeelam will file an issue for it Make Default button is not displayed in brave://settings #21954 (comment))
  • Confirmed that clicking on x closes the first-run dialog

Upgrade profile

  • Installed 1.37.111 and upgrade the profile to 137.113 and confirmed first run dialog is NOT shown in an upgraded profile
  • Installed 1.37.111 and set the brave as a default browser and upgrade the profile to 137.113 and confirmed first run dialog is NOT shown in an upgraded profile and Make Default is removed from the brave://settings/getStarted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop OS/Windows priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants