Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Launch FirstRun dialog on Windows (uplift to 1.37.x) #12692

Merged
merged 3 commits into from
Apr 4, 2022
Merged

Launch FirstRun dialog on Windows (uplift to 1.37.x) #12692

merged 3 commits into from
Apr 4, 2022

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Mar 22, 2022 •
edited by kjozwiak
Loading

Uplift of #12482, #12647
Resolves brave/brave-browser#21464
Resolves brave/brave-browser#21694

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@simonhong
Use first run dialog on Windows
dd6e135 
fix brave/brave-browser#21464
Enabled first run dialog on Windows.
@simonhong
Prepared for using different FirstRun dialog on Win
eb4aaa8 
Modifed FirstRun dialog is used on macOS/Linux.
And we'll use our own FirstRun dialog on Win.
@simonhong
Introduced Windows specific FirstRun dialog
a09befb 
fix brave/brave-browser#21694
@simonhong simonhong requested a review from a team March 22, 2022 05:42
@simonhong simonhong requested a review from a team as a code owner March 22, 2022 05:42
@simonhong simonhong self-assigned this Mar 22, 2022
@github-actions github-actions bot added the potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false label Mar 22, 2022
@kjozwiak
Copy link
Member

As per the discussion during the b-b meeting with @rebron @bsclifton and others, we decided to let this bake for a while and potentially add it into the 1.37.x maintenance release scheduled for April 13th as per https://github.com/brave/brave-browser/wiki/Brave-Release-Schedule#release-channel-dates.

@kjozwiak kjozwiak mentioned this pull request Apr 4, 2022
Closed
kjozwiak
kjozwiak approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.37.x approved. QA has verified the PR using 1.38.x via brave/brave-browser#21464 (comment) & brave/brave-browser#21694 (comment).

@kjozwiak kjozwiak merged commit 45a5801 into 1.37.x Apr 4, 2022
@kjozwiak kjozwiak deleted the uplift_windows_default_dialog_1.37.x branch April 4, 2022 06:32
@kjozwiak kjozwiak mentioned this pull request Apr 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@simonhong simonhong

Labels
potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet
Milestone
1.37.x - Release #5
Development

Successfully merging this pull request may close these issues.
2 participants
@simonhong @kjozwiak