Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up to first run dialog on Windows #21694

Closed
rebron opened this issue Mar 15, 2022 · 4 comments · Fixed by brave/brave-core#12647
Closed

Follow up to first run dialog on Windows #21694

rebron opened this issue Mar 15, 2022 · 4 comments · Fixed by brave/brave-core#12647
Assignees
Labels
onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop OS/Windows priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/exclude

Comments

@rebron
Copy link
Collaborator

rebron commented Mar 15, 2022

Description

Update text and button actions to reflect design.

Design/Expected result

see: #21694 (comment)

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

Follow-up from #21464

@rebron rebron added onboarding Front-end related to helping a new user learn about features within the browser. OS/Windows QA/Yes priority/P2 A bad problem. We might uplift this to the next planned release. labels Mar 15, 2022
@bradleyrichter
Copy link

Title: Ready for the best privacy online?

Body: Set Brave as your default browser to get Brave’s privacy protections on every web page you open.

No button: Maybe later

Yes button: Set Brave as default

Preview:
image

@MadhaviSeelam
Copy link

MadhaviSeelam commented Mar 29, 2022

Verified Complete using

Brave 1.38.70 Chromium: 100.0.4896.46 (Official Build) beta (64-bit)
Revision 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS Windows 11 Version 21H2 (Build 22000.556)

Logged #21954 for Testcases 2, 3, 4

Testcase 1: `Set Brave as default` browser
  • Clean install
  • Launch Brave
  • First run dialog Ready for the best privacy online? is displayed
  • Clicked Set Brave as default button
  • Verified dialog design matches to the mockup
  • Navigated to brave://settings
  • Verified the entry Brave is your default browser in the settings page
set brave as default
Testcase 2: `Make Default` button should be available in `brave://settings`
  • Clean install
  • Launch Brave
  • First run dialog Ready for the best privacy online? is displayed
  • Clicked Maybe later to dismiss the dialog
  • Navigate to brave://settings
  • Verify Default browser entry shows Make default button
  • Click on 'Make default' button to Set Brave as default browser
Testcase 3: Click `x` on the dialog
  • Clean Profile
  • Launch Brave
  • First run dialog Ready for the best privacy online? is displayed
  • Clicked x to dismiss the dialog
  • Navigate to brave://settings
  • Verify Default browser entry shows Make default button
  • Click on 'Make default' button to Set Brave as default browser
Testcase 4: The dialog should display buttons same order as the mockup
  • Clean profile
  • Launch Brave
  • First run dialog Ready for the best privacy online? should be displayed
  • Verified the dialog design matches to the mockup
  • The order of the buttons should be Maybe later followed by Set Brave as default

@MadhaviSeelam MadhaviSeelam added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 29, 2022
@kjozwiak
Copy link
Member

kjozwiak commented Apr 4, 2022

We'll need to re-test this via 1.37.x as we're uplifting it into the 1.37.x maintenance release via brave/brave-core#12692. The above will require 1.37.111 or higher for verification using 1.37.x.

@kjozwiak kjozwiak removed this from the 1.38.x - Beta milestone Apr 4, 2022
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 12, 2022

Verification PASSED on

Brave | 1.37.113 Chromium: 100.0.4896.88 (Official Build) (64-bit)
-- | --
Revision | 4450653bfa91182e85723d8f1dee64dd6ce40ed4-refs/branch-heads/4896@{#1086}
OS | Windows 10 Version 21H2 (Build 19044.1586)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop OS/Windows priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants