Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cr92 followup] Guest menu is missing "Exit" menu item. #16885

Closed
mkarolin opened this issue Jul 9, 2021 · 1 comment · Fixed by brave/brave-core#9394
Closed

[cr92 followup] Guest menu is missing "Exit" menu item. #16885

mkarolin opened this issue Jul 9, 2021 · 1 comment · Fixed by brave/brave-core#9394
Assignees
@mkarolin
Labels
OS/Desktop QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.27.x - Release

Comments

@mkarolin
Copy link
Contributor

mkarolin commented Jul 9, 2021 •
edited
Loading

Currently, clicking on the Guest menu, doesn't show the "Exit" item:

and with multiple windows we show:

whereas Chrome shows the item for either single or multiple windows:

We should maintain parity with upstream here.

STR:

  1. Start Brave
  2. ☰ -> Open Guest Window
  3. In the Guest window, click on the Guest profile menu
  4. Observe popup menu items

Current result:

  • No "Close Guest" menu item

Expected result:

  • "Close Guest" menu item is present
  1. In the Guest Window, ☰ -> New Window
  2. In the Guest Window, click on the Guest profile menu
  3. Observer popup menu items

Current result:

  • "Close 2 windows" menu item is present

Expected result:

  • "Close Guest" menu item is present

cc: @GeetaSarvadnya, @rebron
@mkarolin mkarolin self-assigned this Jul 9, 2021
mkarolin added a commit to brave/brave-core that referenced this issue Jul 9, 2021
@mkarolin
Adds "Exit Guest" menu item to Guest profile menu.
6c3c8b3 
This is to maintain parity with upstream.

* Adds the button for when only a single guest window is open
* Updates button text for when multiple guest windows are open
* Updates callback bindings to use current class name instead of base
  class.
* Removes OnExitButtonClicked method from BraveProfileMenu class as it
  was not working correctly for guest profiles and is also not doing
  anything different from the base class implementation.

Fixes brave/brave-browser#16885
This was referenced Jul 9, 2021
Merged
Merged
@mkarolin mkarolin added this to the 1.28.x - Nightly milestone Jul 12, 2021
@mkarolin mkarolin mentioned this issue Jul 12, 2021
Merged
24 tasks
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Jul 13, 2021
Closed
@GeetaSarvadnya
Copy link

Verification passed on


Brave | 1.27.105 Chromium: 92.0.4515.93 (Official Build) (64-bit)
-- | --
Revision | 6eb43ff7850a1d710c3f827a0555737c74edab5c-refs/branch-heads/4515@{#1378}
OS | Windows 10 OS Version 2004 (Build 19041.1083)

  • Verified the description from [cr92 followup] Guest menu is missing "Exit" menu item. #16885 (comment)

  • Confirmed X Close Guest menu is shown when single Guest window is opened
    image

  • Confirmed click on X Close Guest closes the Guest windows

  • Confirmed 2 open windows menu item along X Close Guest menu is shown when 2 or more Guest windows are opened
    image
    image

  • Confirmed click on X Close Guest closes all the Guest windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
OS/Desktop QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.27.x - Release
Development

Successfully merging a pull request may close this issue.

Adds "Exit Guest" menu item to Guest profile menu. brave/brave-core
3 participants
@LaurenWags @GeetaSarvadnya @mkarolin