Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 91 to Chromium 92 (1.27.x). #9361

Merged
merged 20 commits into from
Jul 14, 2021
Merged

Upgrade from Chromium 91 to Chromium 92 (1.27.x). #9361

merged 20 commits into from
Jul 14, 2021

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Jul 7, 2021 •
edited
Loading

Fixes brave/brave-browser#15316
Fixes brave/brave-browser#15871
Fixes brave/brave-browser#16708
Fixes brave/brave-browser#16712
Fixes brave/brave-browser#16716
Fixes brave/brave-browser#16717
Fixes brave/brave-browser#16718
Fixes brave/brave-browser#16726
Fixes brave/brave-browser#16732
Fixes brave/brave-browser#16773
Fixes brave/brave-browser#16852
Fixes brave/brave-browser#16865
Fixes brave/brave-browser#16877
Fixes brave/brave-browser#16885
Fixes brave/brave-browser#16926

Related PR: brave/brave-browser#16818
Related PR: brave/brave-browser#16948

Uplift from #8545
Uplift from #9288
Uplift from #9290
Uplift from #9292
Uplift from #9297
Uplift from #9294
Uplift from #9303
Uplift from #9302
Uplift from #9340
Uplift from #9372
Uplift from #9391
Uplift from #9389
Uplift from #9394
Uplift from #9420

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin added the CI/run-network-audit Run network-audit label Jul 7, 2021
@mkarolin mkarolin self-assigned this Jul 7, 2021
@mkarolin mkarolin mentioned this pull request Jul 8, 2021
Merged
24 tasks
@mkarolin mkarolin requested a review from a team July 8, 2021 00:42
@mkarolin mkarolin marked this pull request as ready for review July 8, 2021 00:42
@mkarolin mkarolin requested review from zenparsing and removed request for a team July 8, 2021 00:42
goodov
goodov approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member

@goodov goodov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*permission lifetime* lgtm

fmarier
fmarier approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member

@fmarier fmarier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for the change to vendor/bat-native-ads/src/bat/ads/internal/privacy/unblinded_tokens/unblinded_tokens_unittest.cc

AlexeyBarabash
AlexeyBarabash approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ for sync changes

@LaurenWags LaurenWags added this to the 1.27.x - Beta milestone Jul 14, 2021
LaurenWags
LaurenWags approved these changes Jul 14, 2021
View reviewed changes
Copy link
Member

@LaurenWags LaurenWags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 1.27.x is approved after deliberating with @brave/uplift-approvers

bbondy and others added 3 commits July 14, 2021 10:46
@bbondy @mkarolin
Merge pull request #8545 from brave/cr92
5f86395 
Upgrade from Chromium 91 to Chromium 92
@mkarolin
Merge pull request #9288 from brave/maxk-cr92-followup-fix-settings
3e61769 
[cr92 followup] Fixes blank settings page.
@mkarolin
Merge pull request #9290 from brave/maxk-cr92-followup-fix-mac-signing
dfab994 
[cr92 followup] Fixes MacOS signing.
mkarolin and others added 16 commits July 14, 2021 10:47
@mkarolin
Merge pull request #9292 from brave/maxk-revert-tweak_info_plist-change
81a5f5a 
[cr92 followup] Reverts plistlib changes in tweak_info_plist.py.
@bsclifton @mkarolin
Merge pull request #9297 from brave/maxk-revert-unit-tests-in-static-…
2a5a693 
…libs

[cr92 followup] Revert static_library unit test targets
@mkarolin
Merge pull request #9294 from brave/maxk-fix-windows-signing
a087ee2 
[cr92 followup] Fixes signing on Windows.
@bbondy @mkarolin
Merge pull request #9303 from brave/92.0.4515.81
a600eca 
Updated patches from Chromium 92.0.4515.70 to Chromium 92.0.4515.81.
@mkarolin
Merge pull request #9302 from brave/maxk-fix-mac-signing-II
04ceb97 
[cr92 followup] Fixes MacOS signing script
@mkarolin
Conflict-resolved patches from Chromium 91.0.4472.124 to Chromium 92.…
e5be0fb 
…0.4515.81 on 1.27.x branch.
@mkarolin
Updated patches from Chromium 91.0.4472.124 to Chromium 92.0.4515.81 …
4b0fcbf 
…on 1.27.x branch.
@mkarolin
Migrate away from InkDropHostView::AnimateInkDrop()
34ae089 
We should use InkDropHost::AnimateToState() now.

Chromium changes:

https://chromium.googlesource.com/chromium/src/+/7a956cd01727bd626ca2711671935efa0128ee28

commit 7a956cd01727bd626ca2711671935efa0128ee28
Author: Peter Boström <[email protected]>
Date:   Fri May 7 20:08:13 2021 +0000

    Separate InkDropHost from InkDropHostView

    This essentially moves InkDropHostView into a new class with the
    temporary name InkDropHost. All accesses to InkDropHost are done through
    InkDropHostView::ink_drop(). InkDropHostView is now a new trivial View
    subclass which is provides an InkDropHost.

    A latter step will move ink_drop() down to InkDropHostView subclasses.
    Several clean-up steps are missing, but this may be easier to review.

    Bug: 931964
@mkarolin
Migrate away from using ListValue's iterators II.
5e51437 
They are no longer available now and ListValue::GetList() should be
used instead now.

Chromium change:

https://source.chromium.org/chromium/chromium/src/+/fe59284a48bc5a3af8f058b048e3cc1fe260a1b9

commit fe59284a48bc5a3af8f058b048e3cc1fe260a1b9
Author: David Bertoni <[email protected]>
Date:   Thu May 13 22:46:56 2021 +0000

    [CodeHealth] Remove ListValue::begin()/end().

    This CL removes these deprecated member function.

    Bug: 1187107
@simonhong @mkarolin
Merge pull request #9340 from brave/ntp_favicon
865734f 
Hide favicon for NTP in tab UI
@mariospr @mkarolin
Add DEPS rule for ../../../../../../services/network in the right place
d8f587a 
It's confusing to have this in chromium_src/services/network/DEPS when
it's only needed from chromium_src/services/network/public/cpp.
@bsclifton @mkarolin
Merge pull request #9372 from brave/92.0.4515.93_master_107
3ca98d4 
Upgrade patches from Chromium 92.0.4515.81 to Chromium 92.0.4515.93
@bsclifton @mkarolin
Merge pull request #9389 from brave/maxk-revert-prec-headers-unit-tests
774333a 
[cr92 followup] Revert using precompiled headers with unit tests.
@mkarolin
Merge pull request #9391 from brave/maxk-fix-download-item-mixed-content
aea5c77 
Do not show origin in download items with mixed content.
@mkarolin
Merge pull request #9394 from brave/maxk-fix-guest-profile-menu
ac9907d 
Adds "Exit Guest" menu item to Guest profile menu.
@mkarolin
Merge pull request #9420 from brave/maxk-disable-account-data-storage…
db7fa9d 
…-for-passwords

Disables kEnablePasswordsAccountStorage feature.
This was referenced Jul 14, 2021
Merged
Merged
@LaurenWags LaurenWags merged commit d533849 into 1.27.x Jul 14, 2021
@LaurenWags LaurenWags deleted the cr92-1.27.x branch July 14, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orspetol orspetol orspetol approved these changes

@LaurenWags LaurenWags LaurenWags approved these changes

@AlexeyBarabash AlexeyBarabash AlexeyBarabash approved these changes

@goodov goodov goodov approved these changes

@fmarier fmarier fmarier approved these changes

@iefremov iefremov Awaiting requested review from iefremov iefremov is a code owner

@kylehickinson kylehickinson Awaiting requested review from kylehickinson kylehickinson is a code owner

@samartnik samartnik Awaiting requested review from samartnik samartnik is a code owner

@simonhong simonhong Awaiting requested review from simonhong simonhong is a code owner

@zenparsing zenparsing Awaiting requested review from zenparsing

Assignees

@mkarolin mkarolin

Labels
CI/run-network-audit Run network-audit
Projects
None yet
Milestone
1.27.x - Release
Development

Successfully merging this pull request may close these issues.
10 participants
@mkarolin @fmarier @goodov @AlexeyBarabash @LaurenWags @orspetol @bbondy @bsclifton @simonhong @mariospr