Upgrade from Chromium 91 to Chromium 92

[mkarolin]

Upgrade from Chromium 91 to Chromium 92

https://chromium.googlesource.com/chromium/src/+log/91.0.4472.124..92.0.4515.70/?pretty=fuller&n=10000

QA tests:
This is a major Chromium version bump, please do full passes.

Desktop Affected areas:

1. Cosmetic filtering
2. Permission requests
3. Adding profiles
4. Shields and Rewards buttons
5. Saving passwords on Mac and Linux
6. Saving passwords, addresses, and CCs UI
7. Profile menu UI
8. Profile import on Mac

[GeetaSarvadnya]

Verification passed on

Brave | 1.28.64 Chromium: 92.0.4515.81 (Official Build) nightly (64-bit)
-- | --
Revision | dba3af0a9a48954c8b188bc641e651580b7cb7b5-refs/branch-heads/4515@{#1162}
OS | Windows 10 OS Version 2004 (Build 19041.1052)

Profile menu UI and Adding profiles

• Confirmed able to create a new profile via Create a new profile
• Confirmed once the profile is created Manage profiles, Other profiles, + Add and Guest settings are showing up in the profile menu

• Confirmed profile settings can be edited via Manage Profiles
• Confirmed new profiles can be created via + Add
• Confirmed click on Guest redirects to Guest window
• Encountered [cr92 followup] Guest menu is missing "Exit" menu item. #16885 - few settings missing in the Guest window
  
• Confirmed new profiles can be added via +
  
• Confirmed profiles can be edited with custom theme color
  
  

Shields and Rewards buttons

Shields

• Confirmed Shield settings is positioned at the 4th position in sidebar settings as per the Move security and privacy higher in brave://settings #16470
  
• Confirmed site specific shield settings are working as expected
• Confirmed Global shield settings are working as expected
• Confirmed number of blocked items are shown correctly on a opened sites when the shields is ON
• Confirmed number of blocked items are NOT shown on shield when the shields is OFF
  
• Confirmed number of blocked items aren't shown when shields Look & feel settings is toggled OFF
• Confirmed scripts blocking is working as expected
• Installed 1.26.x nightly build and opened few sites and changes shield settings and upgraded profile to 1.28.x nightly and confirmed shield settings are retained after upgrade
• Confirmed shield settings can be changed after the upgrade
• Installed 1.26.x nightly and visit cnn.com and make the shield OFF and upgrade the profile to 1.28.x, confirmed blocked item count is not shown after the upgrade

Rewards

• Confirmed users can enable rewards via BR panel/Brave rewards from hamburger menu/ NTP's
• Verified the rewards onboarding flow via brave://rewrads settings page
• Verified the rewards onboarding flow via BR panel
• Verified the rewards onboarding flow via Tipping banner and confirmed it works as expected
• Confirmed AC/One time tip/Recurring tips works as expected
• Verified the AC/Tips/Monthly Contribution settings and confirmed no settings are missing
• Verified custom tipping and confirmed it works as expected
• Verified the Reset rewards and confirmed it worked as expected
• Verified the new uphold modal UI and confirmed UI is as expected and users can create/connect existing uphold accounts
• Confirmed restart browser is not losing any rewards data

Saving passwords, addresses, and CCs UI

Saving passwords

• Confirmed users are getting save password prompt for Twitter/Uphold
• Confirmed saved passwords can be viewed via Manage passwords
• Not getting save password prompts for Gmail account logins - Logged CR92 - Not getting save password prompt for Gmail accounts #16926
  
• Confirmed passwords can be Copy/Edit/Remove
• Confirmed passwords can be Imported/Exported
  
  

addresses

• Confirmed Addresses can be added via ADD in brave://settings/addresses
• Confirmed added addresses appear in the Addresses and more section
• Confirmed added addresses can be Edited/removed via Edit/Remove option
• Confirmed addresses can be auto filled in an online form
  
  

CC's UI

• Verified the custom UI change in brave://settings page
• Verified the custom UI change in the Create New profile- Guest window
• Verified custom UI change in Profile menu UI
• Verified Password, addresses, brave://settings UI, Profile menu UI and ensured no custom background image showing up

Permission requests

• Verified Permission lifetime flag is enabled by default in nightly
  
  
• Verified that the dropdown items are listed in the ascending order (low to high)
• Verified that the Block forever button correctly sets the value for Location in brave://settings/content to Block
• Verified that the Allow button sets the value for Location in brave://settings/content to Allow
• Verified that the site permission link at the bottom of the dialog links to brave://settings/content
• Verified that Learn more links to placeholder wiki page: https://github.com/brave/brave-browser/wiki/Web-API-Permissions

Allow

	Example	Example	Example

Block

Example	Example	Example	Example

20-seconds, Allow permission_Normal Tab (camera + microphone )

Verified permission prompt was triggered

Verified permissions were granted

Verified permissions were revoked after 20s

20-seconds, Allow permission_Private Tab (camera + microphone )

Verified permission prompt was triggered

Verified permissions were granted

Verified permissions were revoked after 20s

20-seconds, Allow permission_TOR Tab (camera + microphone )

Verified permission prompt was triggered

Verified permissions were granted

Verified permissions were revoked after 20s

Allow forever (location)

• Verified visiting the page triggers permission prompt
• Verified brave://settings/content for Location shows Allow
• Verified after 2 months, permission is still granted

Example	Example	Example

Origin-based behavior, multiple tabs (location)

• Verified visiting browserleaks.com/geo triggers permission prompt
• Verified the permission is granted
• Verified That after closing 1 tab, the permission is still granted
• Verified closing all the related tabs, clears the permission
• Verified visiting browserleaks.com/geo again triggers permission prompt

Example	Example	Example	Example	Example

Consecutive-revocation permissions (location)

• Verified visiting permission.site triggers permission prompt
• Verified Location is allowed for 20 seconds
• Verified visiting https://browserleaks.com/geo triggers permission prompt
• Verified Location is allowed for 20 seconds
• Verified after 20s the allow permission was revoked

Cosmetic filtering

Clean profile cosmetic filtering

• Installed 1.28.74 and opened a CNN.COM site and blocked few elements via Brave->Block element via elector and ensured blocked elements on the sites are hidden
• Opened brave://adblock and ensured new line has been added corresponding to the newly blocked items for cnn.com
• Reload the cnn.com and confirmed blocked elements on the sites are still hidden
• Confirmed elements are not blocked when Quit button is selected
• Confirmed elements are blocked only when Create button is selected

	Example	Example	Example

• Confirmed elements on the cnn.com are blocked when block elements via Brave->Block elements
• Confirmed all the elements on the cnn.com are reappeared when all the blocked items are removed from brave://adblock

Example	Example	Example	Example

Upgrade profile cosmetic filtering

• Install 1.26.x nightly and open nytimes.com and block few elements on the page Brave->Block element via elector and ensured blocked elements on the sites are hidden and then upgrade the profile to 1.28.x nightly
• Confirmed elements on nytimes.com is still blocked after the upgrade
• Confirmed newly blocked elements are added to brave://adblock and ensured a new line has been added corresponding to the newly blocked items for nytimes.com

Example	Example

Verified the issues #14458 and #14294 and ensured no issues are regressed

Gif added for Cosmetic filtering - https://drive.google.com/file/d/1i5_pIewio96aEEpULgKsK-P6aRtTgway/view?usp=sharing

Keyboard shortcuts for search keywords

Confirmed that the Keyboard shortcuts for search keywords have been added in brave://settings/searchEngines page

Space or Tab

• Confirmed when the search keyboard shortcut Space or Tab is selected in brave://settings/searchEngines page, then the user can perform a keyword search using Space and Tab both
• Confirmed user can perform a keyboard search successfully by selecting Space or Tab

Tab

• Confirmed when the search keyboard shortcut Tab is selected in brave://settings/searchEngines page, then the user can perform a keyword search using Tab only
• Confirmed when the search keyboard shortcut Tab is selected in brave://settings/searchEngines page, then the user can't perform a keyword search using Space
• Confirmed user can perform a keyboard search successfully by selecting Tab

CR 92 Specific settings changes

• Confirmed Keyboard shortcuts for search keywords section has been added into brave://settings/searchEngines
  

• Confirmed Font and File handler permissions have been added into brave://settings/content
  

---

Verification passed on

Brave	1.27.105 Chromium: 92.0.4515.93 (Official Build) (64-bit)
Revision	6eb43ff7850a1d710c3f827a0555737c74edab5c-refs/branch-heads/4515@{#1378}
OS	Ubuntu 18.04 LTS

Version

Passwords:

Brave rewards:

Shields:

Profiles:

Cosmetic filtering

Permissions:

---

Verified PASSED using

Brave	1.27.105 Chromium: 92.0.4515.93 (Official Build) (x86_64)
Revision	6eb43ff7850a1d710c3f827a0555737c74edab5c-refs/branch-heads/4515@{#1378}
OS	macOS Version 11.4 (Build 20F71)

cosmetic filtering

example	example	example

permission requests

example	example

adding profiles

example	example

profile-menu UI

example	example

profile import on Mac

example	example

saving passwords

example	example

saving addresses and credit cards

example	example	example	example

Shields

example	example	example

Rewards

example	example

[LaurenWags]

Labeled as release-notes/exclude as this is superseded by #16852. Since this is a major bump, added QA/Test-All-Platforms label. @brave/legacy_qa should still check all items listed in description once we have an RC.

[srirambv]

@mkarolin could you list Android specific changes as well that requires special attention?

[samartnik]

@srirambv I believe this question is to me

Android Affected areas:

1. Stacked overview mode
2. Ads notifications
3. Main settings UI
4. Sync
5. URL bar editing mode

[stephendonner]

Verification PASSED for my few sections which I ran through on macOS.

Brave	1.28.78 Chromium: 92.0.4515.93 (Official Build) nightly (x86_64)
Revision	6eb43ff7850a1d710c3f827a0555737c74edab5c-refs/branch-heads/4515@{#1378}
OS	macOS Version 11.4 (Build 20F71)

Went through:

1. Saving passwords
2. Profile UI
3. Importing other browsers' profiles

No new issues found while doing so.

[srirambv]

Verification passed on OnePlus 6T with Android 10 running 1.27.106 x64 build
Stacked overview mode

• Verified able to view tabs in stacked layout when tab group is disabled
• Verified tab stacking works for both normal and private tabs
• Verified grouped tabs get stacked on top of each other when the setting is disabled
• Verified enabling tab groups regroups the tabs and shows the tab groups correctly

Ads notifications

• Verified Ad notifications stack up properly in notification area
• Verified ad notifications are triggered based on ads per hour setting
• Verified ad notifications are not shown when app is not in foreground if the show ads in background setting is disabled

Main settings UI

• Verified settings UI doesn't have any regressions

Sync

• Verified sync worked as expected
• Verified existing bookmarks sync properly
• Verified bookmarks from other devices sync correctly
• Verified able to join sync chain with QR code or code words
• Verified able to leave the sync chain properly

URL bar editing mode

• Verified able to edit URL's without any issues
• Verified context menu works fine on URL bar

---

Verification passed on Samsung Tab A with Android 10 running 1.27.106 x64 build
Stacked overview mode

• NA for tablet

Ads notifications

• Verified Ad notifications stack up properly in notification area
• Verified ad notifications are triggered based on ads per hour setting
• Verified ad notifications are not shown when app is not in foreground if the show ads in background setting is disabled

Main settings UI

• Verified settings UI doesn't have any regressions

Sync

• Verified sync worked as expected
• Verified existing bookmarks sync properly
• Verified bookmarks from other devices sync correctly
• Verified able to join sync chain with QR code or code words
• Verified able to leave the sync chain properly

URL bar editing mode

• Verified able to edit URL's without any issues
• Verified context menu works fine on URL bar