-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculate account statement from locally persisted state #16028
Comments
Sizing at 2 points |
Verification PASSED on
Verified the test plan from brave/brave-core#10956
Case 1: Verify user is only rewarded if ads are enabled_PASSED
Serving ad notification:
Case 2: Verify users are rewarded after viewing an ad_PASSED
Assigning x amount of BAT for viewed ad
Case 3: Verify confirmations are sent to the backend_PASSEDCase 4: Verify ads are added to 30-day Ads History_PASSEDCase 5: Verify 30-day Ads History is showing ads for the last 30-days_PASSED
Case 6: Verify current earnings this month (estimated) has the correct value_PASSED
Case 7: Verify current earnings this month (estimated) is updated when a user resets Rewards_PASSEDCase 8: Verify "Next payment date" shows the correct value_PASSEDCase 9: Verify "Next payment date" is updated when a user resets Rewards_PASSED
Case 10: Verify "Ads received this month" has the correct value_PASSED
Case 11: Verify "Ads received this month" is updated when a user resets Rewards_PASSED
Case 12: Verify Rewards widget "Earnings" has the correct value_PASSED
Case 13: Verify Rewards widget "Earnings" is updated when a user resets Rewards_PASSED
Case 14: Verify Rewards panel "Estimated Earnings" has the correct value_PASSED
Case 15: Verify Rewards panel "Estimated Earnings" is updated when a user resets Rewards_PASSED
Case 16: Verify Rewards are reset to 0.0 (plus any rewards which were not cashed-in) at midnight on the 1st of each month based on the users local time_PASSEDCase 1:
Case 17: Verify "Your +#.# BAT payout will begin processing in # day." is working as expected_PASSED
Case 18: Verify unblinded payment tokens are removed from confirmations.json when a user resets Rewards_PASSED
Additional testing:
Case 19: Verify failed confirmations are removed from confirmations.json when a user resets Rewards_PASSED
Additional testing:
Case 20: Verify transactions are removed from database.sqlite when a user resets Rewards_PASSED
Case 21: Verify transactions are migrated from confirmations.json to a new transactions table in database.sqlite_PASSEDCase 22: Verify transactions are added to transactions table in database.sqlite_PASSEDCase 23: Verify redeemed_at column for the 'transactions' table in database.sqlite is updated for cashed-out tokens_PASSEDCase 24: Verify next_token_redemption_date_in_seconds is migrated from confirmations.json to brave.brave_ads.rewards.next_time_redemption_at pref_PASSEDCase 25: Verify next token redemption date is working as expected_PASSED
Case 26: Verify day parting frequency cap is working as expected_ PASSEDPrerequisites: To test this scenario created a custom catalog that has a dayParting block that contains the Case1: Test that ads are served in the specific time frame and day_PASSED
dayParting parameters:
Ad serve Logs:
Logs when dayParting start and end min elapses
Case2: Test that ads are served in the specific time frame and day_PASSED
dayParting parameters:
Logs when dayParting start and end min elapses
Case 3: Test that ads are NOT served when dayParting start min and end min is set to 0_PASSED
dayParting parameters:
_Logs when dayParting start and end min set to 0
Case 4: Test that ads are not served when dayParting start and end mins is same_ PASSED
dayParting parameters:
_Logs when dayParting start and end min are same
Case 5: Test that ads are served as usual when dayparting block is empty_PASSED
Case 27: Verify upgrade path from 1.34.x to 1.35.x is working as expected_PASSEDCase 1: Ads switch OFF and then Upgrade to 1.35.x -PASSED
Case 2: View a couple of Ads and then Upgrade to 1.35.x - PASSED
Case 3: View an NTP SI and confirm users are rewarded for viewing an NTPSI and ad notification count increased and then upgrade the profile to 1.35.x - FAILED (known issue #13815)
Case 4: View ads and then reset rewards and then upgrade profile to 1.35.x - PASSED
|
No idea how to test the cc: @tmancey @LaurenWags |
@GeetaSarvadnya see original day part ticket brave/brave-core#6893 with tests (day parting is part of the catalog) |
Verification passed on Samsung Tab A with Android 10 running 1.35.98 x64 build Case 1: Confirm user is only rewarded if ads are enabled - Passed
Case 2: Confirm users are rewarded after viewing an ad - Passed
View
Click
Landed
Dismiss
Case 3: Confirm confirmations are sent to the backend Not testable on Android
Case 4: Confirm ads are added to 30-day Ads History - Not testable on AndroidCase 5: Confirm 30-day Ads History is showing ads for the last 30-days - Not testable on AndroidCase 6: Confirm brave://rewards "Current earnings this month (estimated)" has the correct value - Passed
Case 7: Confirm brave://rewards "Current earnings this month (estimated)" is updated when a user resets Rewards - Failed
Case 8: Confirm brave://rewards "Next payment date" shows the correct value - PassedCase 9: Confirm brave://rewards "Next payment date" is updated when a user resets Rewards - Failed
Case 10: Confirm brave://rewards "Ads received this month" has the correct value - PassedCase 11: Confirm brave://rewards "Ads received this month" is updated when a user resets Rewards - Failed
Case 12: Confirm Rewards widget "Earnings" has the correct value - Not Applicable for AndroidCase 13: Confirm Rewards widget "Earnings" is updated when a user resets Rewards - Failed on reset and Not Applicable on Android for widgetCase 14: Confirm Rewards panel "Estimated Earnings" has the correct value - Passed
Case 15: Confirm Rewards panel "Estimated Earnings" is updated when a user resets Rewards - Failed
Case 16: Confirm Rewards are reset at midnight on the 1st of each month based on the users local time to the total amount of unreconciled transactions for previous months (i.e. carried over) - Partial Passed
Encountered #20795 Case 17: Confirm "Your +#.# BAT payout will begin processing in # day." is working as expected- Passed
Case 18: Confirm unblinded payment tokens are removed from confirmations.json when a user resets Rewards - Not testable on AndroidCase 19: Confirm failed confirmations are removed from confirmations.json when a user resets Rewards - Not testable on Android
Case 20: Confirm transactions are removed from database.sqlite when a user resets Rewards - Not testable on Android
Case 21: Confirm transactions are migrated from confirmations.json to a new transactions table in database.sqlite - Not testable on Android
Case 22: Confirm transactions are added to transactions table in database.sqlite - Not testable on Android
Case 23: Confirm redeemed_at column for the 'transactions' table in database.sqlite is updated for cashed-out tokens - Not testable on Android
Case 24: Confirm next_token_redemption_date_in_seconds is migrated from confirmations.json to brave.brave_ads.rewards.next_time_redemption_at pref - Not testable on AndroidCase 25: Confirm next token redemption date is working as expected - Not testable on Android
Case 26: Confirm day parting frequency cap is working as expected - Not testable on AndroidCase 27: Confirm upgrade path from 1.34.x to 1.35.x is working as expected - Partial PassedCase 1: Ads switch OFF and then Upgrade to 1.35.x -PASSED
16028-Case1.mp4Case 2: View a couple of Ads and then Upgrade to 1.35.x - PASSED
16028-Case2.mp4Case 3: View an NTP SI and confirm users are rewarded for viewing an NTPSI and ad notification count increased and then upgrade the profile to 1.35.x -PASSED
Case 4: View ads and then reset rewards and then upgrade profile to 1.35.x - Failed
|
Verification is PASSED on Vivo X70 Pro with Android 11 running 1.35.98 x64 build
Case 1: Confirm user is only rewarded if ads are enabled - Passed
Case 2: Confirm users are rewarded after viewing an ad - Passed
Verify ads served logs:
Verify Click event:
Verify View event:
Verify Landed event:
Verify Dismissed event:
Case 6: Confirm brave://rewards "Current earnings this month (estimated)" has the correct value - Passed
Case 8: Confirm brave://rewards "Next payment date" shows the correct value - PassedCase 10: Confirm brave://rewards "Ads received this month" has the correct value - PassedCase 14: Confirm Rewards panel "Estimated Earnings" has the correct value - Passed
Case 16: Confirm Rewards are reset at midnight on the 1st of each month based on the users local time to the total amount of unreconciled transactions for previous months (i.e. carried over) - Passed
Case 17: Confirm "Your +#.# BAT payout will begin processing in # day." is working as expected- PassedCase 1: Verify count down message
Case 2: Verify payment arriving message
Case 27: Confirm upgrade path from 1.34.x to 1.35.x is working as expected - PassedCase 1: Ads switch OFF and then Upgrade to 1.35.x -PASSED
Screenrecording_20220201_192735.mp4Case 2: View a couple of Ads and then Upgrade to 1.35.x - PASSED
Screenrecording_20220201_194033.mp4Case 3: View an NTP SI and confirm users are rewarded for viewing an NTPSI and ad notification count increased and then upgrade the profile to 1.35.x -PASSED
Case 4: View ads and then reset rewards and then upgrade profile to 1.35.x - Failed
|
The counter Current earnings this month (estimated) is showing only the Ads not-reconciled. It should also include Ads reconciled in this month (Feb). I tested this from database.sqlite file in Version 1.37.17 Chromium: 98.0.4758.87 (Official Build) nightly (64-bit). Please check. |
@aman-m1 I have checked and the values are correct for me. Please email me at [email protected] with your findings so I can check. |
I have sent. Please check. |
No description provided.
The text was updated successfully, but these errors were encountered: