Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start using rewards button isn't removed from NTP even after enabling rewards in an upgraded profile #20598

Closed
GeetaSarvadnya opened this issue Jan 20, 2022 · 3 comments
Assignees

Comments

@GeetaSarvadnya
Copy link

Description

Found while testing #16028
Start using rewards button isn't removed from NTP even after enabling rewards in an upgraded profile

Steps to Reproduce

  1. Clean install 1.34.x enable rewards
  2. View a couple of ads and reset the rewards
  3. Confirm ads and AC switches are in OFF state
  4. Upgrade the profile 1.35.x
  5. Confirm ads and AC switches are in OFF state
  6. Open a new NTP and click on Start using rewards to enable rewards
  7. Confirm rewards gets enabled
  8. Start using rewards button isn't removed from NTP even after enabling rewards

Actual result:

Expected result:

Start using rewards button should be removed from NTP after enabling rewards

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.35.87 Chromium: 97.0.4692.71 (Official Build) beta (64-bit)
Revision adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS Windows 10 Version 21H2 (Build 19044.1466)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @Miyayes @LaurenWags

@LaurenWags
Copy link
Member

LaurenWags commented Jan 20, 2022

@GeetaSarvadnya this reproduces in 1.34.x as well, correct? (install 1.33.x and upgrade to 1.34.x)

@GeetaSarvadnya
Copy link
Author

@LaurenWags That's correct

@Miyayes
Copy link
Collaborator

Miyayes commented Jan 26, 2022

@rmcfadden3 Might have reproduced.

@zenparsing zenparsing self-assigned this Jan 26, 2022
@zenparsing zenparsing added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jan 26, 2022
@Miyayes Miyayes added priority/P4 Planned work. We expect to get to it "soon". and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels May 25, 2022
@Miyayes Miyayes closed this as not planned Won't fix, can't repro, duplicate, stale May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants