Calculate account statement from locally persisted state #10956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmancey
changed the title
tmancey
force-pushed
the
issues/16028
branch
10 times, most recently
from
e0e4309 to
1422fb8
Compare
tmancey
force-pushed
the
issues/16028
branch
9 times, most recently
from
b35703b to
6c14779
Compare
tmancey
force-pushed
the
issues/16028
branch
from
6c14779 to
ee9eabc
Compare
tmancey
force-pushed
the
issues/16028
branch
14 times, most recently
from
5f5b319 to
841f8d6
Compare
aseren
reviewed
Dec 8, 2021
build/rust/Cargo.lock
Outdated
| @@ -1055,9 +1055,9 @@ dependencies = [ | |||
|
|
|||
| [[package]] | |||
There was a problem hiding this comment.
Do we need to commit changes in this file?
aseren
reviewed
Dec 8, 2021
| @@ -66,19 +66,19 @@ void Account::RemoveObserver(AccountObserver* observer) { | |||
| } | |||
|
|
|||
| bool Account::SetWallet(const std::string& id, const std::string& seed) { | |||
| const WalletInfo last_wallet = wallet_->Get(); | |||
| const WalletInfo& last_wallet = wallet_->Get(); | |||
There was a problem hiding this comment.
In this case adding a reference & dosn't do any optimizations because wallet_->Get() returns a copy of WalletInfo object.
I think const WalletInfo last_wallet = wallet_->Get(); is better here.
There was a problem hiding this comment.
Agreed to followup in a separate issue
aseren
reviewed
Dec 8, 2021
| void Account::TopUpUnblindedTokens() { | ||
| if (!ShouldRewardUser()) { | ||
| return; | ||
| } | ||
|
|
||
| const WalletInfo wallet = GetWallet(); | ||
| const WalletInfo& wallet = GetWallet(); |
There was a problem hiding this comment.
seems like const WalletInfo wallet = GetWallet(); would be better and in the code below.
There was a problem hiding this comment.
Agreed to followup in a separate issue
aseren
approved these changes
Dec 8, 2021
aseren
reviewed
Dec 8, 2021
| namespace ads { | ||
|
|
||
| base::Time GetNextPaymentDate(const TransactionList& transactions) { | ||
| const base::Time& next_token_redemption_at = base::Time::FromDoubleT( |
There was a problem hiding this comment.
These references are also redundant. Agreed to followup in a separate issue
tmancey
force-pushed
the
issues/16028
branch
3 times, most recently
from
7c7d414 to
18410e9
Compare
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#16028
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
confirmations.jsonwhen a user resets Rewardsconfirmations.jsonwhen a user resets Rewardsdatabase.sqlitewhen a user resets Rewardstransactionsare migrated fromconfirmations.jsonto a newtransactionstable indatabase.sqlite(built from a list of transactions for this month, a single transaction for unredeemed transactions for previous months and a single transaction for redeemed transactions last month)transactionstable indatabase.sqliteredeemed_atcolumn for the 'transactions' table indatabase.sqliteis updated for cashed-out tokensnext_token_redemption_date_in_secondsis migrated fromconfirmations.jsontobrave.brave_ads.rewards.next_time_redemption_atpreftransactiontables that have a large amount of transactions (especially on iOS)NOTE:
GET /v1/confirmation/payment/{payment_id}endpoint has been deprecated