Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent estimated earnings counter from ever decreasing unexpectedly #20165

Closed
Miyayes opened this issue Dec 19, 2021 · 4 comments
Closed

Prevent estimated earnings counter from ever decreasing unexpectedly #20165

Miyayes opened this issue Dec 19, 2021 · 4 comments
Assignees
Labels
bug feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android Tab QA Pass-Win64 QA/Yes release-notes/exclude

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Dec 19, 2021

Description

Lots of users report the estimated earnings counter decreasing suddenly. Many users watch the estimated earnings counter like hawks, so any non-monotonically increasing changes will immediately make them distrustful and angry. Even if the estimated earnings counter resolves itself after awhile (e.g., a browser restart or after an hour or so), it should not decrease in this way.

Is it the case that the estimated earnings can never be over-calculated (such that drops in the estimated earnings amount are actually required for accuracy)? If so, then we should be able to prevent it from ever decreasing unexpectedly.

cc: @jsecretan

@Miyayes Miyayes added feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop labels Dec 19, 2021
@Miyayes Miyayes added priority/P2 A bad problem. We might uplift this to the next planned release. bug labels Dec 19, 2021
@tmancey
Copy link
Contributor

tmancey commented Dec 19, 2021

@Miyayes which version of the browser please?

@tmancey
Copy link
Contributor

tmancey commented Dec 19, 2021

@Miyayes do you know the build channel? Thanks

@tmancey tmancey added this to the 1.35.x - Nightly milestone Dec 22, 2021
@tmancey tmancey added the QA/Yes label Dec 22, 2021
@tmancey
Copy link
Contributor

tmancey commented Dec 22, 2021

Closing issue as will be resolved by #16028. QA should test as part of #16028.

@srirambv
Copy link
Contributor

srirambv commented Jan 31, 2022

Verification passed on Samsung Tab A with Android 10 running 1.35.98 x64 build


Verification PASSED on

Brave | 1.35.99 Chromium: 98.0.4758.87 (Official Build) (64-bit)
-- | --
Revision | e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS | Windows 10 Version 21H2 (Build 19044.1503)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android Tab QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Development

No branches or pull requests

4 participants