Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QR code generator to the URL bar #15900

Closed
bsclifton opened this issue May 17, 2021 · 1 comment · Fixed by brave/brave-core#8825
Closed

Add QR code generator to the URL bar #15900

bsclifton opened this issue May 17, 2021 · 1 comment · Fixed by brave/brave-core#8825
Assignees
Labels

Comments

@bsclifton
Copy link
Member

Test plan

  1. Start Brave browser
  2. Navigate to any website (e.g. brave.com)
  3. Click inside the location bar
  4. An action icon shows up in the location bar. When clicked a bubble with QR code shows up.

Description

QR code sharing disabled with #15008 in browser version 1.23

Security review for this feature was recently done and was approved:
https://github.com/brave/security/issues/450

No calls are being made to Google (or elsewhere) to generate the code OR for the URL generated (ex: it's not using a redirect link)

@bsclifton bsclifton self-assigned this May 17, 2021
bsclifton added a commit to brave/brave-core that referenced this issue May 17, 2021
Fixes brave/brave-browser#15900

Also includes cleanup; removes obsolete flags added with
#5435 (this experiment was
removed and enabled by default with Chromium 91)
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label May 17, 2021
@bsclifton bsclifton added this to the 1.26.x - Nightly milestone May 18, 2021
bsclifton added a commit to brave/brave-core that referenced this issue May 18, 2021
Fixes brave/brave-browser#15900

Also includes cleanup; removes obsolete flags added with
#5435 (this experiment was
removed and enabled by default with Chromium 91)
@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 18, 2021
@stephendonner
Copy link

stephendonner commented May 18, 2021

Verified PASSED using the inline testplan with build

Brave 1.26.24 Chromium: 91.0.4472.57 (Official Build) nightly (x86_64)
Revision e3443317fa07f1e9997e4a9c738eddfefc3c0292-refs/branch-heads/4472_54@{#6}
OS macOS Version 11.3.1 (Build 20E241)

Steps:

  1. new profile, started Brave
  2. loaded brave.com
  3. clicked inside the location bar
  4. clicked on the windows-looking QR code icon, to the left of the Brave Shield icon
  5. confirmed that scanning the QR code loaded brave.com
  6. confirmed that scanning the downloaded PNG of the QR code took me to brave.com
  7. changed the prepopulated URL to https://www.mozilla.org/en-US/404, confirmed that the QR-code image updated
  8. scanned the new QR code, both inline and downloaded, and confirmed it took me to the newly-inputted URL (https://www.mozilla.org/en-US/404)
example example brave.com QR code example mozilla.org/en-US/404 QR code
Screen Shot 2021-05-18 at 2 03 44 PM Screen Shot 2021-05-18 at 2 03 49 PM qrcode_brave com Screen Shot 2021-05-18 at 2 08 48 PM qrcode_www mozilla org-404

Verification PASSED on Win 10 x64 using the following build:

Brave | 1.27.24 Chromium: 91.0.4472.77 (Official Build) nightly (64-bit)
--- | ---
Revision | 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS | Windows 10 OS Version 2009 (Build 19042.1023)
  • ensured that the QR code is being displayed within the URL bar when visiting brave.com
    • scanned it with an iOS device and ensured that the correct page is being loaded
    • ensured that you can download the QR image and use it afterwards rather than using it within Brave
  • ensured that Create QR code for this image appears in the context menu when right clicking on images
    • scanned it with an iOS device and ensured that the correct page is being loaded
    • ensured that you can download the QR image and use it afterwards rather than using it within Brave
Example Example Example
QR1 QR2 QR3

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 18, 2021
@rebron rebron changed the title Re-enable sharing-qr-code-generator feature Add QR code generator to URL bar Jun 21, 2021
@rebron rebron changed the title Add QR code generator to URL bar Add QR code generator to the URL bar Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants