Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable QR code sharing for a URL (uplift to 1.25.x) #8837

Closed
wants to merge 1 commit into from
Closed

Re-enable QR code sharing for a URL (uplift to 1.25.x) #8837

wants to merge 1 commit into from

Conversation

bsclifton
Copy link
Member

Uplift of #8825
Fixes brave/brave-browser#15900

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@bsclifton
Re-enable QR code sharing for a URL
c40176f 
Fixes brave/brave-browser#15900

Also includes cleanup; removes obsolete flags added with
#5435 (this experiment was
removed and enabled by default with Chromium 91)
@bsclifton bsclifton added this to the 1.25.x - Beta milestone May 18, 2021
@bsclifton bsclifton requested a review from a team May 18, 2021 05:14
@bsclifton bsclifton self-assigned this May 18, 2021
@bsclifton bsclifton changed the title Re-enable QR code sharing for a URL Re-enable QR code sharing for a URL (uplift to 1.25.x) May 18, 2021
@kjozwiak
Copy link
Member

Closing this as we decided that we're going to leave this in 1.26.x via #8825 and let it ride the train.

@kjozwiak kjozwiak closed this May 18, 2021
@kjozwiak kjozwiak removed the request for review from a team May 18, 2021 18:28
@kjozwiak kjozwiak removed this from the 1.25.x - Beta milestone May 18, 2021
@bsclifton bsclifton deleted the bsc-chromium-cleanup-1.25.x branch June 10, 2021 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
invalid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bsclifton @kjozwiak