Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bravify Chromium's QR Dino #11606

Closed
jonathansampson opened this issue Sep 5, 2020 · 5 comments · Fixed by brave/brave-core#8946
Closed

Bravify Chromium's QR Dino #11606

jonathansampson opened this issue Sep 5, 2020 · 5 comments · Fixed by brave/brave-core#8946
Assignees
Labels
branding design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/exclude

Comments

@jonathansampson
Copy link
Contributor

jonathansampson commented Sep 5, 2020

Description

Chromium 85 shipped with a QR Code generator for sharing URLs and Web Authentication. This feature can be enabled within brave://flags/#sharing-qr-code-generator. Once enabled, users are able to generate a QR Code for the current URL via the context menu, or the address bar:

image

Actual result:

image

Expected result:

image

image

image

@jonathansampson jonathansampson added OS/Android Fixes related to Android browser functionality OS/Desktop labels Sep 5, 2020
@bsclifton bsclifton added design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. branding labels Sep 8, 2020
@bsclifton
Copy link
Member

bsclifton commented May 17, 2021

Per @mkarolin the dino version of the file lives at https://source.chromium.org/chromium/chromium/src/+/master:components/qr_code_generator/dino_image.h

We should be able to create a chromium_src override for this 😄

@Brave-Matt
Copy link

Chiming in here because this has actually been mentioned/requested a few times on socials. Plus one! :)
🚫 🦖
➕ 🦁

mkarolin added a commit to brave/brave-core that referenced this issue May 27, 2021
Replaces the dino with the Brave lion.

Fixes brave/brave-browser#11606
@mkarolin mkarolin self-assigned this May 27, 2021
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label May 27, 2021
@kjozwiak
Copy link
Member

kjozwiak commented Jun 1, 2021

We'll need to get this uplifted into 1.26.x after discussing with @rebron during today's b-b triage/planning meeting. QR code was enabled and slated to be released in 1.26.x via #15900.

@srirambv
Copy link
Contributor

Removing Android label as there is no QR Code generated when a link is opened. @jonathansampson @mkarolin Please add a test plan for Android if it is required to be checked as I couldn't find a way to generate the QR code either via context menu on links or via URL bar or flags.

@srirambv srirambv removed the OS/Android Fixes related to Android browser functionality label Jun 14, 2021
@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jun 14, 2021
@LaurenWags
Copy link
Member

Verified passed with

Brave | 1.26.59 Chromium: 91.0.4472.101 (Official Build) beta (x86_64)
-- | --
Revision | af52a90bf87030dd1523486a1cd3ae25c5d76c9b-refs/branch-heads/4472@{#1462}
OS | macOS Version 10.15.7 (Build 19H1030)

Testing of QR code functionality is covered under #15900 (comment).

For this issue, confirmed the Brave branding of the QR code being generated from URL bar, the downloaded file, and from context menu.

QR code generated from URL bar Downloaded QR code image QR code generated from context menu
URL bar qrcode_brave com-download context menu

While testing I did encounter and log #16403. This issue reproduces in Chrome though and is not unique to Brave or this branding change.

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branding design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants