-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bravify Chromium's QR Dino #11606
Comments
Per @mkarolin the dino version of the file lives at https://source.chromium.org/chromium/chromium/src/+/master:components/qr_code_generator/dino_image.h We should be able to create a chromium_src override for this 😄 |
Chiming in here because this has actually been mentioned/requested a few times on socials. Plus one! :) |
Replaces the dino with the Brave lion. Fixes brave/brave-browser#11606
Removing Android label as there is no QR Code generated when a link is opened. @jonathansampson @mkarolin Please add a test plan for Android if it is required to be checked as I couldn't find a way to generate the QR code either via context menu on links or via URL bar or flags. |
Verified passed with
Testing of QR code functionality is covered under #15900 (comment). For this issue, confirmed the Brave branding of the QR code being generated from URL bar, the downloaded file, and from context menu.
While testing I did encounter and log #16403. This issue reproduces in Chrome though and is not unique to Brave or this branding change. |
Description
Chromium 85 shipped with a QR Code generator for sharing URLs and Web Authentication. This feature can be enabled within brave://flags/#sharing-qr-code-generator. Once enabled, users are able to generate a QR Code for the current URL via the context menu, or the address bar:
Actual result:
Expected result:
The text was updated successfully, but these errors were encountered: