Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 89 to Chromium 90. #14037

Closed
mkarolin opened this issue Feb 8, 2021 · 2 comments · Fixed by #14038 or brave/brave-core#7866
Closed

Upgrade from Chromium 89 to Chromium 90. #14037

mkarolin opened this issue Feb 8, 2021 · 2 comments · Fixed by #14038 or brave/brave-core#7866
Assignees
Labels
Chromium/upgrade major Major version bump. (ex: Chromium 88 to 89) OS/Android Fixes related to Android browser functionality OS/Desktop QA/No QA Pass-Win64 QA/Test-Plan-Specified release-notes/exclude

Comments

@mkarolin
Copy link
Contributor

mkarolin commented Feb 8, 2021

Upgrade from Chromium 89.0.4389.105 to Chromium 90.0.4430.30

https://chromium.googlesource.com/chromium/src/+log/89.0.4389.105..90.0.4430.30/?pretty=fuller&n=10000

QA tests:
This is a major Chromium version bump, please do full passes.

Desktop Affected areas:

  • Sync
  • Avatar menu
  • Ad notifications
  • WebUI (settings, extensions) for having correct brave styling
  • Private, Tor, Guest windows for correct brave styling
  • Rewards UI (in settings and in popup) for correct strings (no unfilled placeholders with brackets)
  • Profile picker (add profile, manage profiles) - this has new UI
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Mar 29, 2021

Verification passed on


Brave | 1.24.29 Chromium: 90.0.4430.41 (Official Build) nightly (64-bit)
-- | --
Revision | e9c92b1eaca8487e212f3f6bc081fdb6d4863759-refs/branch-heads/4430@{#723}
OS | Windows 10 OS Version 2004 (Build 19041.867)

Verified the desktop affected areas mentioned in #14037 (comment)

Avatar menu and profile picker

  • Logged CR90 - Icon used in the Guest mode button is not as per the brave brand #15000
  • Open brave://settings/manageProfile and ensured that the Pick a theme color section is been added to the manage profile page
    image
  • Click on Create a new profile from the hamburger menu and ensured that Customize your Brave profile window is opened with Done, Create a desktop shortcut and pick a theme colors section
    image
  • Ensured that user can edit the default avatar menu icon and theme color by selecting the new avatar icon from Pick an avatar modal and color from Pick a theme color
    image
    image
  • Ensured that the Create a Desktop shortcut icon is selected by default in Customize your Brave profile popup modal
  • Ensured profile shortcut is created in the desktop when Create a Desktop shortcut icon is selected
  • Ensured profile shortcut is NOT created in the desktop when Create a Desktop shortcut icon is unselected
  • Ensured that created profile is displayed under Manage Profiles popup modal
    image
  • Ensured that the profile can be edited/deleted via Edit/Delete option
    image
  • Ensured edited Avatar icon and theme color is reflected in the Manager profile popup modal and same is retained in the profile
    image
    image
  • Ensured Guest window is opened upon clicking on the Guest Mode button in the Manage profile popup modal
  • Ensured that the new profiles can be added by clicking on the Add + button in the Manage profile popup modal
  • Ensured multiple profiles can be added in multiple rows and a vertical scrollbar is provided in the manager profile popup
    image
  • Open a Guest window and ensured that new profiles can be added via Manager profile settings or Add + icon
  • Profiles created via Guest windows can be Edited/Deleted vis Edit/Delete options
  • Ensured that profile shortcuts are created for the profiles which are created via Guest window
  • Ensured that click on Guest window profile shortcuts in desktop opens up normal/regular profile window
  • Ensured custom colors can be selected for theme
    image

Sync

Rewards UI

Ad notifications

[16368:4100:0329/223401.222:VERBOSE1:ads_service_impl.cc(1797)] Timeout ad notification with uuid e66d51d7-42c7-4d28-ac72-c9cd702a76b8 in 120 seconds

Private, Tor, Guest windows - Looks good

WebUI (settings, extensions) - Looks good

@kjozwiak
Copy link
Member

kjozwiak commented Apr 7, 2021

Labeling as QA/No & release-notes/exclude in favour of #15052.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chromium/upgrade major Major version bump. (ex: Chromium 88 to 89) OS/Android Fixes related to Android browser functionality OS/Desktop QA/No QA Pass-Win64 QA/Test-Plan-Specified release-notes/exclude
Projects
None yet
5 participants