Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CW and IPFS settings from the Guest window settings #14998

Closed
GeetaSarvadnya opened this issue Mar 29, 2021 · 1 comment · Fixed by brave/brave-core#8445
Closed

Remove CW and IPFS settings from the Guest window settings #14998

GeetaSarvadnya opened this issue Mar 29, 2021 · 1 comment · Fixed by brave/brave-core#8445
Assignees
Labels
feature/global-settings Settings at browser level independent of shields settings OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/include

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Mar 29, 2021

Description

CW and IPFS settings can't be enabled or access from the Guest window hence remove CW and IPFS settings from the Guest window settings

Steps to Reproduce

NA

Actual result:

image (17)

Expected result:

Remove CW and IPFS settings from the Guest window settings

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.24.29 Chromium: 90.0.4430.41 (Official Build) nightly (64-bit)
Revision e9c92b1eaca8487e212f3f6bc081fdb6d4863759-refs/branch-heads/4430@{#723}
OS Windows 10 OS Version 2004 (Build 19041.867)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @rebron @bbondy

Please refer slack thread for additional details https://bravesoftware.slack.com/archives/C7VLGSR55/p1617014853246400

@GeetaSarvadnya GeetaSarvadnya added feature/global-settings Settings at browser level independent of shields settings QA/Yes QA/Test-Plan-Specified OS/Desktop labels Mar 29, 2021
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Apr 6, 2021
@spylogsster spylogsster added this to the 1.25.x - Nightly milestone Apr 7, 2021
@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 7, 2021
@stephendonner
Copy link

Verified PASSED using

Brave 1.24.53 Chromium: 90.0.4430.51 (Official Build) nightly (x86_64)
Revision 32e5fa33a31641bded70a90e60121060691e7125-refs/branch-heads/4430@{#927}
OS macOS Version 11.2.3 (Build 20D91)

Steps to verify:

  1. from a regular tab/window, clicked on hamburger menu
  2. clicked on Open Guest Window option
  3. opened brave://settings
  4. scrolled down

Confirmed there are no IPFS nor Crypto Wallet settings panels present in Guest Window mode.

Screen Shot 2021-04-07 at 1 03 56 PM

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/global-settings Settings at browser level independent of shields settings OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants