Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Learn More to Learn more to maintain consistency across the browser #14944

Closed
GeetaSarvadnya opened this issue Mar 25, 2021 · 7 comments · Fixed by brave/brave-core#8535
Labels
feature/global-settings Settings at browser level independent of shields settings good first issue needs-text-change This change requires some careful wording. OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/exclude suggestion

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Mar 25, 2021

Description

Rename Learn More to Learn more to maintain consistency across the browser

Steps to Reproduce

  1. Open brave 1.24.25
  2. Navigate to brave://settings/ipfs
  3. Look for 1st IPFS setting which has the Lean More link mentioned

Actual result:

image

Expected result:

Should be Learn more

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.24.19 Chromium: 90.0.4430.30 (Official Build) nightly (64-bit)
Revision 5674335ff855e43f3bccf8cfc29a779bdf0d067f-refs/branch-heads/4430@{#532}
OS Windows 10 OS Version 2004 (Build 19041.867)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @karenkliu @brave/legacy_qa @rebron

@GeetaSarvadnya GeetaSarvadnya changed the title Rename Learn More to Learn more` to maintain consistency across the browser Rename Learn More to Learn more to maintain consistency across the browser Mar 25, 2021
@bsclifton bsclifton added needs-text-change This change requires some careful wording. feature/global-settings Settings at browser level independent of shields settings labels Mar 25, 2021
@rebron rebron added good first issue priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Mar 26, 2021
@Ayushsunny
Copy link

I would like to fix this issue.

@gordod26
Copy link

I'll also give it a shot for my first issue if @Ayyushsunny doesn't get to it.

@Ayushsunny
Copy link

I'll also give it a shot for my first issue if @Ayyushsunny doesn't get to it.

I am Working on it now.

@Ayushsunny
Copy link

Hello @srirambv Sir, Can you please ask them to review as I've done this time correctly brave/brave-core#8535 (comment)

@srirambv
Copy link
Contributor

This is fixed by brave/brave-core#8535

@stephendonner
Copy link

Nice catch, @GeetaSarvadnya, and thanks for the fix, @Ayushsunny!

Verified FIXED using

Brave 1.25.46 Chromium: 90.0.4430.93 (Official Build) nightly (x86_64)
Revision 4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS macOS Version 11.3 (Build 20E232)

Steps:

  1. loaded brave://settings/ipfs
  2. looked at the Learn more text and confirmed spelling/case

Screen Shot 2021-04-28 at 4 38 01 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/global-settings Settings at browser level independent of shields settings good first issue needs-text-change This change requires some careful wording. OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/exclude suggestion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants