Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vimeo pubs info is not getting downloaded 1.18.68 onwards #12968

Closed
GeetaSarvadnya opened this issue Dec 1, 2020 · 9 comments · Fixed by brave/brave-site-specific-scripts#36

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 1, 2020

Description

Found while testing #6462
Vimeo pubs info is not getting downloaded 1.18.68 onwards

Steps to Reproduce

  1. Clean profile 1.18.68 launch brave using staging flag
  2. Enable rewards via BR panel
  3. Claim UGP grants
  4. Open https://vimeo.com/willchristiansen or https://vimeo.com/bravelaurenwags in NTP
  5. Click on BR panel
  6. Pubs info isn't displayed

Actual result:

image
image

Expected result:

Pubs info should be shown in BR panel

Reproduces how often:

Always

Brave version (brave://version info)

Brave 1.18.68 Chromium: 87.0.4280.67 (Official Build) dev (64-bit)
Revision 0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS Windows 10 OS Version 2004 (Build 19041.630)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @marshall @emerick @rebron

@emerick
Copy link
Contributor

emerick commented Dec 8, 2020

@GeetaSarvadnya Does a browser restart between steps 2 and 3 fix this for you?

@GeetaSarvadnya
Copy link
Author

@emerick I have verified the issue again in 1.18.69. Restart the browser did not fix the issue. The issue is still reproducible

@emerick emerick self-assigned this Dec 10, 2020
@emerick
Copy link
Contributor

emerick commented Dec 10, 2020

Vimeo and Twitch are configured in Greaselion.json as requiring a minimum Brave version of 1.19. From what I recall, they didn't make the cutoff for 1.18.

https://github.com/brave/brave-site-specific-scripts/blob/master/Greaselion.json#L158

cc: @marshall

@LaurenWags
Copy link
Member

Vimeo was working in 1.18.x and component version 1.0.38 per #11465 (comment)

Could be related to updated component version 1.0.39?

@emerick
Copy link
Contributor

emerick commented Dec 11, 2020

@LaurenWags Yep, you're exactly right. When we added auto-contribution support to Greaselion, base Vimeo support was accidentally changed to target 1.19; only Vimeo a-c should target 1.19. This is the commit that did it: brave/brave-site-specific-scripts@a9d8e63#diff-d8a0512d00370bd50bcfb84761c13fb01190e05f68b97785805735b6d9e0f19cL104. Will fix, thank you!

@emerick
Copy link
Contributor

emerick commented Dec 11, 2020

Fix will be in Greaselion 1.0.40.

@kjozwiak
Copy link
Member

kjozwiak commented Jan 5, 2021

Verification PASSED on Win 10 x64 using the following build:

Brave | 1.18.77 Chromium: 87.0.4280.101 (Official Build) (64-bit)
-- | --
Revision | 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS | Windows 10 OS Version 2009 (Build 19042.685)

Used the following dev component using --use-dev-goupdater-url:

image

Staging - Running through https://vimeo.com/bravelaurenwags and ensured that all the information is correctly being displayed via the panels as per the following:

Example Example Example Example
image image image image

Staging - Running through https://vimeo.com/willchristiansen and ensured that all the information is correctly being displayed via the panels as per the following:

Example Example Example Example
image image image image

Production - Running through https://vimeo.com/willchristiansen and ensured that all the information is correctly being displayed via the panels as per the following:

Example Example
image image

Also went through the following cases:


Verified passed with

Brave	1.18.77 Chromium: 87.0.4280.101 (Official Build) (x86_64)
Revision	9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS	macOS Version 10.15.7 (Build 19H15)

Used dev component version 1.0.40:
Component

Staging - Running through https://vimeo.com/bravelaurenwags and ensured that all the information is correctly being displayed via the panels as per the following:

Example Example Example
Screen Shot 2021-01-05 at 4 35 11 PM Screen Shot 2021-01-05 at 4 35 22 PM Screen Shot 2021-01-05 at 4 35 32 PM

Staging - Running through https://vimeo.com/354953087 and ensured that all the information is correctly being displayed via the panels as per the following:

Example Example Example
Screen Shot 2021-01-05 at 4 36 23 PM Screen Shot 2021-01-05 at 4 36 33 PM Screen Shot 2021-01-05 at 4 36 41 PM

Staging - Running through https://vimeo.com/willchristiansen and ensured that all the information is correctly being displayed via the panels as per the following:

Example Example Example
Screen Shot 2021-01-05 at 4 40 11 PM Screen Shot 2021-01-05 at 4 40 21 PM Screen Shot 2021-01-05 at 4 40 30 PM

Production - Running through https://vimeo.com/willchristiansen and ensured that all the information is correctly being displayed via the panels as per the following:

Example Example
Screen Shot 2021-01-05 at 4 47 32 PM Screen Shot 2021-01-05 at 4 47 40 PM

Also went through the following cases:


Verified passed with

Brave	1.19.76 Chromium: 87.0.4280.101 (Official Build) dev (64-bit)
Revision	9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS	Linux

Used dev component version 1.0.40:
Screen Shot 2021-01-06 at 2 55 00 PM

Staging - Running through https://vimeo.com/bravelaurenwags and ensured that all the information is correctly being displayed via the panels as per the following:

Example Example Example
Screen Shot 2021-01-06 at 3 19 49 PM Screen Shot 2021-01-06 at 3 19 58 PM Screen Shot 2021-01-06 at 3 20 05 PM

Staging - Running through https://vimeo.com/354953087 and ensured that all the information is correctly being displayed via the panels as per the following:

Example Example Example
Screen Shot 2021-01-06 at 3 33 06 PM Screen Shot 2021-01-06 at 3 33 14 PM Screen Shot 2021-01-06 at 3 33 28 PM

Production - Running through https://vimeo.com/willchristiansen and ensured that all the information is correctly being displayed via the panels as per the following:

Example Example Example
Screen Shot 2021-01-06 at 3 35 21 PM Screen Shot 2021-01-06 at 3 35 30 PM Screen Shot 2021-01-06 at 3 35 39 PM

Verification PASSED on Mint 19.1 x64 using the following build:

Brave | 1.19.76 Chromium: 87.0.4280.101 (Official Build) dev (64-bit)
--- | ---
Revision | 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS | Linux

Used the following dev component using --use-dev-goupdater-url:

image

Production - Running through https://vimeo.com/pakocampo and ensured that all the information is correctly being displayed via the panels as per the following:

Example Example Example Example
image image image image

Production - Running through https://vimeo.com/christxstar and ensured that all the information is correctly being displayed via the panels as per the following:

Example Example Example Example
image image image image

Also went through the following cases:

@kjozwiak
Copy link
Member

kjozwiak commented Jan 5, 2021

Only thing that I noticed is that visiting https://vimeo.com/willchristiansen doesn't always display the verified checkmark via the rewards panel while using staging. However, working fine when using production. Assuming this is fine as we're editing a lot of data on staging. CCing @LaurenWags to make sure she's seeing the same thing and this doesn't affect production.

@LaurenWags
Copy link
Member

Can confirm I see the same as @kjozwiak in #12968 (comment) on staging, however this does not occur on production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment