-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vimeo pubs info is not getting downloaded 1.18.68 onwards #12968
Vimeo pubs info is not getting downloaded 1.18.68 onwards #12968
Comments
@GeetaSarvadnya Does a browser restart between steps 2 and 3 fix this for you? |
@emerick I have verified the issue again in |
Vimeo and Twitch are configured in https://github.com/brave/brave-site-specific-scripts/blob/master/Greaselion.json#L158 cc: @marshall |
Vimeo was working in 1.18.x and component version 1.0.38 per #11465 (comment) Could be related to updated component version 1.0.39? |
@LaurenWags Yep, you're exactly right. When we added auto-contribution support to Greaselion, base Vimeo support was accidentally changed to target 1.19; only Vimeo a-c should target 1.19. This is the commit that did it: brave/brave-site-specific-scripts@a9d8e63#diff-d8a0512d00370bd50bcfb84761c13fb01190e05f68b97785805735b6d9e0f19cL104. Will fix, thank you! |
Fix will be in Greaselion |
Verification PASSED on
Used the following
Also went through the following cases:
Verified passed with
Used dev component version 1.0.40:
Also went through the following cases:
Verified passed with
Used dev component version 1.0.40:
Verification PASSED on
Used the following
Also went through the following cases:
|
Only thing that I noticed is that visiting https://vimeo.com/willchristiansen doesn't always display the verified checkmark via the rewards panel while using |
Can confirm I see the same as @kjozwiak in #12968 (comment) on |
Description
Found while testing #6462
Vimeo pubs info is not getting downloaded 1.18.68 onwards
Steps to Reproduce
Actual result:
Expected result:
Pubs info should be shown in BR panel
Reproduces how often:
Always
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc: @brave/legacy_qa @marshall @emerick @rebron
The text was updated successfully, but these errors were encountered: