-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore all from deleted publisher doesn't restore all #1441
Comments
Did not reproduce on macOS. After clicking 'Restore All' link the entire line went away and all sites were restored to the list.
|
@LaurenWags I think it happens when we have 11 or more sites. It seems to restore enough to make current list 10. |
@jasonrsadler hm, I tried with 12 sites on dev (I can't get more than 10 on Beta due to another issue) and I'm still not able to repro
|
@LaurenWags disregard. I was reproducing on beta. Just tried again on dev macOS and seems to be working. |
Found the actual steps which causes this issue
Either publisher should not be added back to the list until its removed from the excluded list or if its getting added back automatically it should not be counted in excluded list. cc: @NejcZdovc @bbondy @rebron this needs to be prioritized for release build |
@srirambv @NejcZdovc @rebron Reproduced with steps from #1441 (comment)
|
@srirambv @LaurenWags Can you verify if this could be related or the cause? When you are excluding sites are you clicking the 'X' more than once before the site has a chance to go away (It goes away really fast on a release build but this reproduces easily on a dev build) @srirambv I notice in your graphic above it shows 10 listed with 1 excluded = 11 but as you're excluding, the total number of sites (excluded + non-excluded) goes up. |
@jasonrsadler I definitely did not click x more than once, however I just tried the steps from #1441 (comment) and was unable to reproduce the issue using
|
Will close this one and let's retest it in the latest master, where brave/brave-core#797 will land as well |
Verification passed on
Used Test Plan from brave/brave-core#797 and STR from OP and comments. Verification passed on
Verified passed with
|
Description
Restore all doesn't get removed after restoring all deleted sites
Steps to Reproduce
Show all
to see the full list of publishersRestore All
from the publisher window. Removed site gets added but still shows 1 excluded siteActual result:
Expected result:
Restore all should not show any value for excluded list. Defeats the purpose of restore all
Reproduces how often:
Easy
Brave version (chrome://version info)
Reproducible on current release:
Website problems only:
Additional Information
cc: @LaurenWags @kjozwiak @NejcZdovc
The text was updated successfully, but these errors were encountered: