Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Brave Rewards extension non-persistent #6462

Closed
bershanskiy opened this issue Oct 14, 2019 · 2 comments · Fixed by brave/brave-core#6978
Closed

Make Brave Rewards extension non-persistent #6462

bershanskiy opened this issue Oct 14, 2019 · 2 comments · Fixed by brave/brave-core#6978
Assignees
@emerick
Labels
feature/rewards OS/Desktop perf priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.18.x - Release

Comments

@bershanskiy
Copy link

Description

Make Brave Rewards extension non-persistent via manifest key persistent: false, allowing extension to be unloaded when not in active use (read when the popup UI is not shown). This should save one process and ~19MB of RAM.

Steps to Reproduce

  1. Open browser
  2. Open task manager
  3. Observe the process called "Extension: Brave Rewards"

Actual result:

rewards

Expected result:

Brave Rewards process is not running, since the popup is closed.

Reproduces how often:

All the time.

Brave version (brave://version info)

Brave 0.69.132 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Linux
JavaScript V8 7.7.299.11
Flash (Disabled)
User Agent Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/77.0.3865.90 Safari/537.36
Command Line /usr/bin/brave-browser-stable --enable-dom-distiller --disable-domain-reliability --disable-chrome-google-url-tracking-client --no-pings --extension-content-verification=enforce_strict --extensions-install-verification=enforce --enable-features=NewExtensionUpdaterService,WebUIDarkMode,SimplifyHttpsIndicator --disable-features=AudioServiceOutOfProcess,AutofillServerCommunication,LookalikeUrlNavigationSuggestionsUI,UnifiedConsent --flag-switches-begin --flag-switches-end
Executable Path /opt/brave.com/brave/brave-browser
Profile Path /home/anton/.config/BraveSoftware/Brave-Browser/Default

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes.
  • Can you reproduce this issue with the beta channel? Yes.
  • Can you reproduce this issue with the dev channel? Yes.
  • Can you reproduce this issue with the nightly channel? Yes.

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A, but yes.
  • Does the issue resolve itself when disabling Brave Rewards? Yes.
  • Is the issue reproducible on the latest version of Chrome? N/A.

Miscellaneous Information:

The following bugs are related:
@petemill
Copy link
Member

petemill commented Oct 15, 2019 •
edited
Loading

Right now this is difficult to achieve because the extension:

  • Uses the webRequest API (due to inline tipping). Once this is removed to a different extension, this will be further possible.
  • Keeps data required in-memory without re-syncing from primary source of data. This is unneccessary. Should be re-architected to retrieve data when needed, and not try to keep a secondary source of data in-sync.

Instead, #3436 is more achievable and achieves the result of non-rewards users not having rewards-related memory use.

@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. and removed 1.0-suggestion labels Oct 18, 2019
@NejcZdovc NejcZdovc mentioned this issue Aug 31, 2020
Closed
15 tasks
@NejcZdovc NejcZdovc assigned NejcZdovc and emerick and unassigned NejcZdovc Oct 28, 2020
@NejcZdovc NejcZdovc mentioned this issue Oct 28, 2020
Merged
33 tasks
@NejcZdovc NejcZdovc added this to the 1.18.x - Nightly milestone Nov 11, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Nov 23, 2020 •
edited by GeetaSarvadnya
Loading

Verification in progress with

Brave	1.18.59 Chromium: 87.0.4280.67 (Official Build) dev (x86_64)
Revision	0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS	macOS Version 10.14.6 (Build 18G6042)

Verified test plan from brave/brave-core#6978. Each of the below cases/sub cases was completed using a fresh profile.

Website - laurenwags.github.io
  1. Rewards panel test
  • Confirmed onboarding shown on clean profile via panel
  • After dismissing onboarding, claimed UGP with clean (staging) profile
  • Confirmed able to tip via panel using UGP
  • Confirmed tip showed on brave://rewards and brave://rewards-internals
Screen Shot 2020-11-23 at 10 33 43 AM Screen Shot 2020-11-23 at 10 34 00 AM Screen Shot 2020-11-23 at 10 34 07 AM Screen Shot 2020-11-23 at 10 34 19 AM

  1. N/A (Inline tipping test)

  2. Extension test

  • Confirmed only Brave extension is running on a clean profile
Screen Shot 2020-11-23 at 10 37 01 AM Screen Shot 2020-11-23 at 10 37 45 AM
  • Confirmed clicking on the BAT logo in URL bar to open the panel started the Rewards extension
Screen Shot 2020-11-23 at 10 39 19 AM
YouTube - youtube.com/user/jjdsampson
  1. Rewards panel test
  • Confirmed onboarding shown on clean profile via panel
  • After dismissing onboarding, claimed UGP with clean (staging) profile
  • Confirmed able to tip via panel using UGP
  • Confirmed tip showed on brave://rewards and brave://rewards-internals
Screen Shot 2020-11-23 at 10 47 47 AM Screen Shot 2020-11-23 at 10 48 08 AM Screen Shot 2020-11-23 at 10 48 20 AM Screen Shot 2020-11-23 at 10 49 07 AM Screen Shot 2020-11-23 at 10 49 27 AM

  1. N/A (Inline tipping test)

  2. Extension test

  • Confirmed only Brave extension is running on a clean profile
Screen Shot 2020-11-23 at 11 34 33 AM
  • Confirmed clicking on the BAT logo in URL bar to open the panel started the Rewards extension
Screen Shot 2020-11-23 at 11 35 23 AM Screen Shot 2020-11-23 at 11 35 54 AM
YouTube - https://www.youtube.com/channel/UCD7siefto4I33L4U61IU5LQ
  1. Rewards panel test
  • Confirmed onboarding shown on clean profile via panel
  • After dismissing onboarding, claimed UGP with clean (staging) profile
  • Confirmed able to tip via panel using UGP
  • Confirmed tip showed on brave://rewards Tip section, Monthly Statement, and brave://rewards-internals Contributions tab
Screen Shot 2020-11-23 at 12 01 35 PM Screen Shot 2020-11-23 at 12 01 53 PM Screen Shot 2020-11-23 at 12 01 59 PM Screen Shot 2020-11-23 at 12 02 06 PM Screen Shot 2020-11-23 at 12 02 24 PM

  1. N/A (Inline tipping test)

  2. Extension test

  • Confirmed only Brave extension is running on a clean profile
Screen Shot 2020-11-23 at 11 55 48 AM
  • Confirmed clicking on the BAT logo in URL bar to open the panel started the Rewards extension
Screen Shot 2020-11-23 at 11 56 44 AM Screen Shot 2020-11-23 at 11 57 07 AM
YouTube - https://www.youtube.com/watch?v=RFUt3wDGt-w
  1. Rewards panel test
  • Confirmed onboarding shown on clean profile via panel
  • After dismissing onboarding, claimed UGP with clean (staging) profile
  • Confirmed able to tip via panel using UGP
  • Confirmed tip showed on brave://rewards Tip section, Monthly Statement, and brave://rewards-internals Contributions tab
Screen Shot 2020-11-23 at 1 14 03 PM Screen Shot 2020-11-23 at 1 14 21 PM Screen Shot 2020-11-23 at 1 14 27 PM Screen Shot 2020-11-23 at 1 14 34 PM Screen Shot 2020-11-23 at 1 14 47 PM

  1. N/A (Inline tipping test)

  2. Extension test

  • Confirmed only Brave extension is running on a clean profile
Screen Shot 2020-11-23 at 1 12 15 PM
  • Confirmed clicking on the BAT logo in URL bar to open the panel started the Rewards extension
Screen Shot 2020-11-23 at 1 13 10 PM Screen Shot 2020-11-23 at 1 13 25 PM
Twitter - twitter.com/emerick
  1. Rewards panel test
  • Confirmed onboarding shown on clean profile via panel
  • After dismissing onboarding, claimed UGP with clean (staging) profile
  • Confirmed able to tip via panel using UGP
  • Confirmed tip showed on brave://rewards Tip section, Monthly Statement, and brave://rewards-internals Contributions tab
Panel tip Screen Shot 2020-11-23 at 1 56 03 PM Screen Shot 2020-11-23 at 1 56 11 PM Screen Shot 2020-11-23 at 1 56 19 PM Screen Shot 2020-11-23 at 1 56 31 PM
  1. In-line tipping test
  • Confirmed onboarding shown on clean profile via in-line tip button on tipping banner
  • Confirmed after selecting "Maybe Later" I was presented with the tipping options
  • Clicking on "add funds" link opens brave://rewards in a new tab, where I can claim staging UGP grant
  • Confirmed clicking back over to the publisher tab allowed me to tip via in-line tip button
  • Confirmed tip showed on brave://rewards Tip section, Monthly Statement, and brave://rewards-internals Contributions tab
in-line tip Screen Shot 2020-11-23 at 1 58 49 PM Screen Shot 2020-11-23 at 1 58 55 PM Screen Shot 2020-11-23 at 1 59 02 PM Screen Shot 2020-11-23 at 1 59 19 PM
  1. Extension test
  • Confirmed only Brave extension is running on a clean profile
clean profile no rewards extension
  • Confirmed clicking on the BAT logo in URL bar to open the panel started the Rewards extension
open panel
  • Starting with a clean profile again, confirmed clicking on the in-line tip button to open the tipping banner started the Rewards extension
open in-line tip
GitHub - https://github.com/brave/brave-browser/commits
  1. Rewards panel test
  • Confirmed onboarding shown on clean profile via panel
  • After dismissing onboarding, claimed UGP with clean (staging) profile
  • Confirmed able to tip via panel using UGP
  • Note: in this case the publisher is not verified, so tip goes to Pending list. Wallet balance is not reduced.
panel tip Screen Shot 2020-11-23 at 3 08 38 PM
  1. In-line tipping test
  • Confirmed onboarding shown on clean profile via in-line tip button on tipping banner
  • Confirmed after selecting "Maybe Later" I was presented with the tipping options
  • Clicking on "add funds" link opens brave://rewards in a new tab, where I can claim staging UGP grant
  • Confirmed clicking back over to the publisher tab allowed me to tip via in-line tip button
  • Confirmed tip showed on brave://rewards Tip section, Monthly Statement, and brave://rewards-internals Contributions tab
Screen Shot 2020-11-23 at 3 11 01 PM Screen Shot 2020-11-23 at 3 11 12 PM Screen Shot 2020-11-23 at 3 11 20 PM Screen Shot 2020-11-23 at 3 11 27 PM Screen Shot 2020-11-23 at 3 11 41 PM
  1. Extension test
  • Confirmed only Brave extension is running on a clean profile
clean profile GH no Rewards Extension
  • Confirmed clicking on the BAT logo in URL bar to open the panel started the Rewards extension
open panel
  • Starting with a clean profile again, confirmed clicking on the in-line tip button to open the tipping banner started the Rewards extension
open inline tip
GitHub - https://github.com/LaurenWags
  1. Rewards panel test
  • Confirmed onboarding shown on clean profile via panel
  • After dismissing onboarding, claimed UGP with clean (staging) profile
  • Confirmed able to tip via panel using UGP
  • Confirmed tip showed on brave://rewards Tip section, Monthly Statement, and brave://rewards-internals Contributions tab
Screen Shot 2020-11-23 at 3 25 25 PM Screen Shot 2020-11-23 at 3 25 39 PM Screen Shot 2020-11-23 at 3 25 47 PM Screen Shot 2020-11-23 at 3 25 55 PM Screen Shot 2020-11-23 at 3 26 08 PM

  1. In-line tipping test - N/A on this URL

  2. Extension test

  • Confirmed only Brave extension is running on a clean profile
clean profile GH profile no BR Extension
  • Confirmed clicking on the BAT logo in URL bar to open the panel started the Rewards extension
open panel
GitHub - https://github.com/brave/brave-browser/ pull/12811
  1. Rewards panel test
  • Confirmed onboarding shown on clean profile via panel
  • After dismissing onboarding, claimed UGP with clean (staging) profile
  • Confirmed able to tip via panel using UGP
  • Note: in this case the publisher is not verified, so tip goes to Pending list. Wallet balance is not reduced.
panel tip Screen Shot 2020-11-23 at 3 53 34 PM
  1. In-line tipping test
  • Confirmed onboarding shown on clean profile via in-line tip button on tipping banner
  • Confirmed after selecting "Maybe Later" I was presented with the tipping options
  • Clicking on "add funds" link opens brave://rewards in a new tab, where I can claim staging UGP grant
  • Confirmed clicking back over to the publisher tab allowed me to tip via in-line tip button
  • Confirmed tip showed on brave://rewards Tip section, Monthly Statement, and brave://rewards-internals Contributions tab
inline tip Screen Shot 2020-11-23 at 3 51 20 PM Screen Shot 2020-11-23 at 3 51 27 PM Screen Shot 2020-11-23 at 3 51 34 PM Screen Shot 2020-11-23 at 3 51 48 PM
  1. Extension test
  • Confirmed only Brave extension is running on a clean profile
clean profile GH PR no extension
  • Confirmed clicking on the BAT logo in URL bar to open the panel started the Rewards extension
open panel
  • Starting with a clean profile again, confirmed clicking on the in-line tip button to open the tipping banner started the Rewards extension
open in-line 
Brave	1.18.61 Chromium: 87.0.4280.67 (Official Build) dev (x86_64)
Revision	0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS	macOS Version 10.14.6 (Build 18G6042)
GitHub - https://github.com/brave/brave-browser/ issues/12771
  1. Rewards panel test
  • Confirmed onboarding shown on clean profile via panel
  • After dismissing onboarding, claimed UGP with clean (staging) profile
  • Confirmed able to tip via panel using UGP
  • Note: in this case the publisher is not verified, so tip goes to Pending list. Wallet balance is not reduced.
panel tip Screen Shot 2020-11-24 at 10 48 20 AM
  1. In-line tipping test
  • Confirmed onboarding shown on clean profile via in-line tip button on tipping banner
  • Confirmed after selecting "Maybe Later" I was presented with the tipping options
  • Clicking on "add funds" link opens brave://rewards in a new tab, where I can claim staging UGP grant
  • Confirmed clicking back over to the publisher tab allowed me to tip via in-line tip button
  • Confirmed tip showed on brave://rewards Tip section, Monthly Statement, and brave://rewards-internals Contributions tab
banner tip Screen Shot 2020-11-24 at 10 51 26 AM Screen Shot 2020-11-24 at 10 51 34 AM Screen Shot 2020-11-24 at 10 51 42 AM Screen Shot 2020-11-24 at 10 52 04 AM
  1. Extension test
  • Confirmed only Brave extension is running on a clean profile
clean profile GH issue no extension
  • Confirmed clicking on the BAT logo in URL bar to open the panel started the Rewards extension
open panel
  • Starting with a clean profile again, confirmed clicking on the in-line tip button to open the tipping banner started the Rewards extension
open banner
Reddit - https://www.reddit.com/user/alex_the_brave
  1. Rewards panel test
  • Confirmed onboarding shown on clean profile via panel
  • After dismissing onboarding, claimed UGP with clean (staging) profile
  • Confirmed able to tip via panel using UGP
  • Confirmed tip showed on brave://rewards Tip section, Monthly Statement, and brave://rewards-internals Contributions tab
panel tip Screen Shot 2020-11-24 at 11 06 32 AM Screen Shot 2020-11-24 at 11 06 43 AM Screen Shot 2020-11-24 at 11 06 54 AM Screen Shot 2020-11-24 at 11 07 06 AM
  1. In-line tipping test
  • Confirmed onboarding shown on clean profile via in-line tip button on tipping banner
  • Confirmed after selecting "Maybe Later" I was presented with the tipping options
  • Clicking on "add funds" link opens brave://rewards in a new tab, where I can claim staging UGP grant
  • Confirmed clicking back over to the publisher tab allowed me to tip via in-line tip button
  • Confirmed tip showed on brave://rewards Tip section, Monthly Statement, and brave://rewards-internals Contributions tab
Screen Shot 2020-11-24 at 11 10 58 AM Screen Shot 2020-11-24 at 11 11 06 AM Screen Shot 2020-11-24 at 11 11 14 AM Screen Shot 2020-11-24 at 11 11 27 AM Screen Shot 2020-11-24 at 11 11 41 AM
  1. Extension test
  • Confirmed only Brave extension is running on a clean profile
clean profile reddit profile no extension
  • Confirmed clicking on the BAT logo in URL bar to open the panel started the Rewards extension
open panel
  • Starting with a clean profile again, confirmed clicking on the in-line tip button to open the tipping banner started the Rewards extension
open banner
Reddit - https://old.reddit.com/r/brave_browser/comments/g79s8n/is_there_a_way_to_remove_the_tip_button/
  1. Rewards panel test
  • Confirmed onboarding shown on clean profile via panel
  • After dismissing onboarding, claimed UGP with clean (staging) profile
  • Confirmed able to tip via panel using UGP
  • Note: in this case the publisher is not verified, so tip goes to Pending list. Wallet balance is not reduced.
panel tip Screen Shot 2020-11-24 at 11 25 17 AM
  1. In-line tipping test
  • Confirmed onboarding shown on clean profile via in-line tip button on tipping banner
  • Confirmed after selecting "Maybe Later" I was presented with the tipping options
  • Clicking on "add funds" link opens brave://rewards in a new tab, where I can claim staging UGP grant
  • Confirmed clicking back over to the publisher tab allowed me to tip via in-line tip button
  • Confirmed tip showed on brave://rewards Tip section, Monthly Statement, and brave://rewards-internals Contributions tab
banner tip Screen Shot 2020-11-24 at 11 31 51 AM Screen Shot 2020-11-24 at 11 31 58 AM Screen Shot 2020-11-24 at 11 32 05 AM Screen Shot 2020-11-24 at 11 32 17 AM
  1. Extension test
  • Confirmed only Brave extension is running on a clean profile
clean profile subreddit no extension
  • Confirmed clicking on the BAT logo in URL bar to open the panel started the Rewards extension
open panel
  • Starting with a clean profile again, confirmed clicking on the in-line tip button to open the tipping banner started the Rewards extension
open banner
Vimeo - https://vimeo.com/bravelaurenwags
  1. Rewards panel test
  • Confirmed onboarding shown on clean profile via panel
  • After dismissing onboarding, claimed UGP with clean (staging) profile
  • Confirmed able to tip via panel using UGP
  • Confirmed tip showed on brave://rewards Tip section, Monthly Statement, and brave://rewards-internals Contributions tab
panel tip Screen Shot 2020-11-24 at 11 36 21 AM Screen Shot 2020-11-24 at 11 36 30 AM Screen Shot 2020-11-24 at 11 36 42 AM Screen Shot 2020-11-24 at 11 36 53 AM

  1. In-line tipping test - N/A

  2. Extension test

  • Confirmed only Brave extension is running on a clean profile
clean profile vimeo profile no extension
  • Confirmed clicking on the BAT logo in URL bar to open the panel started the Rewards extension
open panel

Verification passed on


Brave | 1.18.66 Chromium: 87.0.4280.67 (Official Build) dev (64-bit)
-- | --
Revision | 0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS | Windows 10 OS Version 2004 (Build 19041.630)

Verified test plan from brave/brave-core#6978. Each of the below cases/sub cases was completed using a fresh profile.

Website - DDG
  1. Rewards panel test
  • Confirmed onboarding shown on clean profile via panel
  • After dismissing onboarding, claimed UGP with clean (staging) profile
  • Confirmed able to tip via panel using UGP
  • Confirmed tip showed on brave://rewards and brave://rewards-internals

image
image
image
image
image

  1. N/A (Inline tipping test)

  2. Extension test

  • Confirmed only Brave extension is running on a clean profile
    image
    image

  • Confirmed clicking on the BAT logo in URL bar to open the panel started the Rewards extension
    image

YouTube - youtube.com/user/jjdsampson
  1. Rewards panel test
  • Confirmed onboarding shown on clean profile via panel
  • After dismissing onboarding, claimed UGP with clean (staging) profile
  • Confirmed able to tip via panel using UGP
  • Confirmed tip showed on brave://rewards and brave://rewards-internals

image
image
image
image
image

  1. N/A (Inline tipping test)

  2. Extension test

  • Confirmed only Brave extension is running on a clean profile
    image

Confirmed clicking on the BAT logo in URL bar to open the panel started the Rewards extension
image

YouTube - https://www.youtube.com/channel/UCD7siefto4I33L4U61IU5LQ
  1. Rewards panel test
  • Confirmed onboarding shown on clean profile via panel
  • After dismissing onboarding, claimed UGP with clean (staging) profile
  • Confirmed able to tip via panel using UGP
  • Confirmed tip showed on brave://rewards Tip section, Monthly Statement, and brave://rewards-internals Contributions tab

image
image
image
image
image

  1. N/A (Inline tipping test)

  2. Extension test

  • Confirmed only Brave extension is running on a clean profile

image

Confirmed clicking on the BAT logo in URL bar to open the panel started the Rewards extension
image
image

YouTube - https://www.youtube.com/watch?v=RFUt3wDGt-w
  1. Rewards panel test
  • Confirmed onboarding shown on clean profile via panel
  • After dismissing onboarding, claimed UGP with clean (staging) profile
  • Confirmed able to tip via panel using UGP
  • Confirmed tip showed on brave://rewards Tip section, Monthly Statement, and brave://rewards-internals Contributions tab

image
image
image
image
image

  1. N/A (Inline tipping test)

  2. Extension test

  • Confirmed only Brave extension is running on a clean profile
    image

Confirmed clicking on the BAT logo in URL bar to open the panel started the Rewards extension
image
image

Twitter - twitter.com/emerick
  1. Rewards panel test
  • Confirmed onboarding shown on clean profile via panel
  • After dismissing onboarding, claimed UGP with clean (staging) profile
  • Confirmed able to tip via panel using UGP
  • Confirmed tip showed on brave://rewards Tip section, Monthly Statement, and brave://rewards-internals Contributions tab

image
image
image
image
image

  1. In-line tipping test
  • Confirmed onboarding shown on clean profile via in-line tip button on tipping banner
  • Confirmed after selecting "Maybe Later" I was presented with the tipping options
  • Clicking on "add funds" link opens brave://rewards in a new tab, where I can claim staging UGP grant
  • Confirmed clicking back over to the publisher tab allowed me to tip via in-line tip button
  • Confirmed tip showed on brave://rewards Tip section, Monthly Statement, and brave://rewards-internals Contributions tab

image
image
image

image
image
image

  1. Extension test
  • Confirmed only Brave extension is running on a clean profile

image
image

  • Confirmed clicking on the BAT logo in URL bar to open the panel started the Rewards extension
    image

  • Starting with a clean profile again, confirmed clicking on the in-line tip button to open the tipping banner started the Rewards extension
    image

GitHub - https://github.com/brave/brave-browser/commits
  1. Rewards panel test
  • Confirmed onboarding shown on clean profile via panel
  • After dismissing onboarding, claimed UGP with clean (staging) profile
  • Confirmed able to tip via panel using UGP
  • Note: in this case the publisher is not verified, so tip goes to Pending list. Wallet balance is not reduced.

image
image

  1. In-line tipping test
  • Confirmed onboarding shown on clean profile via in-line tip button on tipping banner
  • Confirmed after selecting "Maybe Later" I was presented with the tipping options
  • Clicking on "add funds" link opens brave://rewards in a new tab, where I can claim staging UGP grant
  • Confirmed clicking back over to the publisher tab allowed me to tip via in-line tip button
  • Confirmed tip showed on brave://rewards Tip section, Monthly Statement, and brave://rewards-internals Contributions tab

image
image
image
image
image
image
image

  1. Extension test

  • Confirmed only Brave extension is running on a clean profile
    image
    image

  • Confirmed clicking on the BAT logo in URL bar to open the panel started the Rewards extension
    image

  • Starting with a clean profile again, confirmed clicking on the in-line tip button to open the tipping banner started the Rewards extension
    image

GitHub - https://github.com/LaurenWags
  1. Rewards panel test
  • Confirmed onboarding shown on clean profile via panel
  • After dismissing onboarding, claimed UGP with clean (staging) profile
  • Confirmed able to tip via panel using UGP
  • Confirmed tip showed on brave://rewards Tip section, Monthly Statement, and brave://rewards-internals Contributions tab
    image
    image
    image
    image
    image
    image

  1. In-line tipping test - N/A on this URL

  2. Extension test

  • Confirmed only Brave extension is running on a clean profile
    image
    image

  • Confirmed clicking on the BAT logo in URL bar to open the panel started the Rewards extension
    image

GitHub - https://github.com/brave/brave-browser/ pull/12811
  1. Rewards panel test
  • Confirmed onboarding shown on clean profile via panel
  • After dismissing onboarding, claimed UGP with clean (staging) profile
  • Confirmed able to tip via panel using UGP
  • Note: in this case the publisher is not verified, so tip goes to Pending list. Wallet balance is not reduced.

image
image
image

  1. In-line tipping test
  • Confirmed onboarding shown on clean profile via in-line tip button on tipping banner
  • Confirmed after selecting "Maybe Later" I was presented with the tipping options
  • Clicking on "add funds" link opens brave://rewards in a new tab, where I can claim staging UGP grant
  • Confirmed clicking back over to the publisher tab allowed me to tip via in-line tip button
  • Confirmed tip showed on brave://rewards Tip section, Monthly Statement, and brave://rewards-internals Contributions tab

image
image
image
image
image
image
image

  1. Extension test

  • Confirmed only Brave extension is running on a clean profile
    image
    image

  • Confirmed clicking on the BAT logo in URL bar to open the panel started the Rewards extension
    image

  • Starting with a clean profile again, confirmed clicking on the in-line tip button to open the tipping banner started the Rewards extension

image

GitHub - https://github.com/brave/brave-browser/ issues/12771
  1. Rewards panel test
  • Confirmed onboarding shown on clean profile via panel
  • After dismissing onboarding, claimed UGP with clean (staging) profile
  • Confirmed able to tip via panel using UGP
  • Note: in this case the publisher is not verified, so tip goes to Pending list. Wallet balance is not reduced.
    image
    image
    image
  1. In-line tipping test
  • Confirmed onboarding shown on clean profile via in-line tip button on tipping banner
  • Confirmed after selecting "Maybe Later" I was presented with the tipping options
  • Clicking on "add funds" link opens brave://rewards in a new tab, where I can claim staging UGP grant
  • Confirmed clicking back over to the publisher tab allowed me to tip via in-line tip button
  • Confirmed tip showed on brave://rewards Tip section, Monthly Statement, and brave://rewards-internals Contributions tab

image
image
image
image
image
image

  1. Extension test

  • Confirmed only Brave extension is running on a clean profile
    image
    image

  • Confirmed clicking on the BAT logo in URL bar to open the panel started the Rewards extension
    image

  • Starting with a clean profile again, confirmed clicking on the in-line tip button to open the tipping banner started the Rewards extension
    image


Brave | 1.18.68 Chromium: 87.0.4280.67 (Official Build) dev (64-bit)
-- | --
Revision | 0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS | Windows 10 OS Version 2004 (Build 19041.630)
Reddit - https://www.reddit.com/user/alex_the_brave
  1. Rewards panel test
  • Confirmed onboarding shown on clean profile via panel
  • After dismissing onboarding, claimed UGP with clean (staging) profile
  • Confirmed able to tip via panel using UGP
  • Confirmed tip showed on brave://rewards Tip section, Monthly Statement, and brave://rewards-internals Contributions tab

image
image
image
image
image

  1. In-line tipping test
  • Confirmed onboarding shown on clean profile via in-line tip button on tipping banner
  • Confirmed after selecting "Maybe Later" I was presented with the tipping options
  • Clicking on "add funds" link opens brave://rewards in a new tab, where I can claim staging UGP grant
  • Confirmed clicking back over to the publisher tab allowed me to tip via in-line tip button
  • Confirmed tip showed on brave://rewards Tip section, Monthly Statement, and brave://rewards-internals Contributions tab

image
image
image
image
image
image
image

  1. Extension test
  • Confirmed only Brave extension is running on a clean profile

image
image

  • Confirmed clicking on the BAT logo in URL bar to open the panel started the Rewards extension
    image

  • Starting with a clean profile again, confirmed clicking on the in-line tip button to open the tipping banner started the Rewards extension
    image

Reddit - https://old.reddit.com/r/brave_browser/comments/g79s8n/is_there_a_way_to_remove_the_tip_button/
  1. Rewards panel test
  • Confirmed onboarding shown on clean profile via panel
  • After dismissing onboarding, claimed UGP with clean (staging) profile
  • Confirmed able to tip via panel using UGP
  • Note: in this case the publisher is not verified, so tip goes to Pending list. Wallet balance is not reduced.

image
image

  1. In-line tipping test
  • Confirmed onboarding shown on clean profile via in-line tip button on tipping banner
  • Confirmed after selecting "Maybe Later" I was presented with the tipping options
  • Clicking on "add funds" link opens brave://rewards in a new tab, where I can claim staging UGP grant
  • Confirmed clicking back over to the publisher tab allowed me to tip via in-line tip button
  • Confirmed tip showed on brave://rewards Tip section, Monthly Statement, and brave://rewards-internals Contributions tab

image
image
image
image
image
image

  1. Extension test

  • Confirmed only Brave extension is running on a clean profile
    image
    image

  • Confirmed clicking on the BAT logo in URL bar to open the panel started the Rewards extension
    image

  • Starting with a clean profile again, confirmed clicking on the in-line tip button to open the tipping banner started the Rewards extension
    image

Vimeo - https://vimeo.com/bravelaurenwags

Logged #12968 Unable to test Vimeo due to this issue

@LaurenWags LaurenWags mentioned this issue Nov 23, 2020
Closed
This was referenced Nov 24, 2020
Closed
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Dec 1, 2020
Closed
@LaurenWags LaurenWags mentioned this issue Dec 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerick emerick

Labels
feature/rewards OS/Desktop perf priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.18.x - Release
Development

Successfully merging a pull request may close this issue.

Move Greaselion handling into Brave extension brave/brave-core
8 participants
@petemill @bsclifton @emerick @rebron @NejcZdovc @LaurenWags @GeetaSarvadnya @bershanskiy