Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline tip button is shown in Reddit/Twitter/GH even though tipping is disabled in Tips settings #12870

Closed
GeetaSarvadnya opened this issue Nov 24, 2020 · 17 comments
Closed

Inline tip button is shown in Reddit/Twitter/GH even though tipping is disabled in Tips settings #12870

GeetaSarvadnya opened this issue Nov 24, 2020 · 17 comments
Assignees
@emerick
Labels
feature/rewards OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Test-Plan-Specified QA/Yes regression release-notes/exclude
Milestone
1.31.x - Release

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 24, 2020 •
edited
Loading

Description

Inline tip button is shown in Reddit/Twitter/GH even though tipping is disabled in Tips settings

Steps to Reproduce

  1. Clean profile 1.18.59 - launch brave with staging flag
  2. Enable rewards and claim UGP grants
  3. Disable all tip settings from Tips settings
  4. Open verified Twitter/GH/Reddit pubs and verify the Inline tip button is shown in Reddit/Twitter/GH

Actual result:

Inline tip button is shown in Reddit/Twitter/GH even though tipping is disabled in Tips settings
Twitter:
image

Reddit:
image

GH:
image

Expected result:

Inline tip button should not be shown in Reddit/Twitter/GH when tipping is disabled in Tips settings

Reproduces how often:

Always

Brave version (brave://version info)

Brave 1.18.59 Chromium: 87.0.4280.67 (Official Build) dev (64-bit)
Revision 0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS Windows 10 OS Version 2004 (Build 19041.630)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @rebron @NejcZdovc @zenparsing @emerick
@emerick
Copy link
Contributor

emerick commented Nov 24, 2020

We currently require a browser restart when changing the inline tipping settings.

@LaurenWags
Copy link
Member

Occurs as a result of brave/brave-core#6978.

@GeetaSarvadnya can you confirm browser restart resolves this per @emerick comment in #12870 (comment)?

@GeetaSarvadnya
Copy link
Author

@LaurenWags @emerick Restart browser fixes the issue, hence closing the issue. Thanks!

@GeetaSarvadnya
Copy link
Author

As per the slack conversion, the issue is kept open https://bravesoftware.slack.com/archives/CB0KCRCQN/p1606226717465100?thread_ts=1606221529.464500&cid=CB0KCRCQN

@stgarf
Copy link

stgarf commented Dec 10, 2020 •
edited
Loading

What the hay is all this tipping and crypto crap. Time to leave brave in the dust.

@JoranDox
Copy link

Brave rewards has been turned off in my browser for months now, but I suddenly see tips buttons on twitter, here on github, etc. What gives?

@LaurenWags
Copy link
Member

LaurenWags commented Dec 14, 2020 •
edited
Loading

@jonathansampson was your twitter page the active tab/in focus when launching the browser after enabling in-line tips? if so, I believe that's a known issue - see #11825 cc @emerick for confirmation.

@jonathansampson
Copy link
Contributor

@LaurenWags It was. Thanks!

@rebron rebron mentioned this issue Dec 15, 2020
Closed
@Megawatt7
Copy link

Megawatt7 commented Dec 15, 2020 •
edited
Loading

I will be downloading the copycat version without all this crazy bloatware. Being unable to remove these tip buttons is worse than being monopolized by Amazon. At least they actually provide jobs and stuff. With Brave they're STUFFING THESE BAT LOGO TIPS DOWN YOUR THROAT

@johntringham johntringham mentioned this issue Dec 17, 2020
Merged
32 tasks
@emerick emerick self-assigned this Dec 17, 2020
@snowbound
Copy link

I feel if the Brave Rewards is disabled in the browser then do NOT enable any of new addons like tipping. Do not turn Brave into a cat and mouse game with your end-user who has no interest in Brave Rewards/BAT etc. I have to look at your subreddit to see how the heck to disable the annoying triangles that just mysteriously appeared one day.

@TheFeelTrain
Copy link

Even after a restart the tip buttons are not going away.

Version 1.18.77 Chromium: 87.0.4280.101 (Official Build)

@emerick emerick mentioned this issue Jan 19, 2021
Merged
23 tasks
@emerick
Copy link
Contributor

emerick commented Jan 22, 2021

Inline tipping is no longer shown if Rewards icon is hidden, per brave/brave-core#7655.

This particular issue will now focus on surfacing a message to the user that toggling inline tipping requires a browser restart. This will most likely take the form of a small "Relaunch" button (similar to the current behavior when changing the language for the browser UI in brave://settings).

cc: @Miyayes @zenparsing @marshall

@GeetaSarvadnya GeetaSarvadnya mentioned this issue Feb 2, 2021
Closed
@emerick emerick mentioned this issue Mar 29, 2021
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Apr 20, 2021
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Jul 9, 2021
Closed
@kjozwiak kjozwiak mentioned this issue Jul 27, 2021
Closed
@emerick
Copy link
Contributor

emerick commented Sep 8, 2021 •
edited
Loading

The remaining issue here (#12870 (comment)) was addressed in #13341.

@emerick emerick closed this as completed Sep 8, 2021
@emerick emerick added this to the 1.31.x - Nightly milestone Sep 10, 2021
@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Sep 17, 2021 •
edited
Loading

Verification passed on

Brave | 1.31.50 Chromium: 94.0.4606.50 (Official Build) nightly (64-bit)
-- | --
Revision | 0c1ac2c4842a4746c27c937c1a0453f98da1a972-refs/branch-heads/4606@{#1049}
OS | Windows 10 Version 21H1 (Build 19043.1165)
  • Verified the STR from the description
Inline Tip_Github
  • Confirmed inline tip button is shown in Github when the GH checkbox is selected in the Tips settings
  • Confirmed inline tip button isn't shown in Github when the GH checkbox is NOT selected in the Tips settings
  • Confirmed inline tip button re-appeared in Github when the GH checkbox is re-selected in the Tips settings
    GH inline tip
Inline Tip_Twitter
  • Confirmed inline tip button is shown in Twitter when the Twitter checkbox is selected in the Tips settings
  • Confirmed inline tip button isn't shown in Twitter when the Twitter checkbox is NOT selected in the Tips settings
  • Confirmed inline tip button re-appeared in Twitter when the Twitter checkbox is re-selected in the Tips settings
    Twitter inline tip
Inline Tip_Reddit
  • Confirmed inline tip button is shown in Reddit when the Reddit checkbox is selected in the Tips settings
  • Confirmed inline tip button isn't shown in Reddit when the Reddit checkbox is NOT selected in the Tips settings
  • Confirmed inline tip button re-appeared in Reddit when the Reddit checkbox is re-selected in the Tips settings
    Reddit inline tip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerick emerick

Labels
feature/rewards OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Test-Plan-Specified QA/Yes regression release-notes/exclude
Projects
None yet
Milestone
1.31.x - Release
Development

No branches or pull requests
10 participants
@snowbound @jonathansampson @stgarf @kjozwiak @emerick @JoranDox @TheFeelTrain @LaurenWags @GeetaSarvadnya @Megawatt7