-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide in-line tipping buttons for users who've already hidden the BAT / Brave Rewards icon #13341
Comments
So, let's say someone creates a new Brave profile. Judging by the premise of this issue, the advertisements would still be enabled. What would happen if they then went on to disable the Rewards icon after this feature was enabled? I'm presuming this aspect hasn't been considered; in that case, perhaps it would be wise to have a tete-a-tete with the Rewards Settings to disable this option too? Any feedback / opinions on this? |
@resynth1943, when you say "new profile" do you mean just a new profile for an existing user, or do you mean a brand new user who's downloaded Brave for the first time? @emerick I think if a user disables the Brave Rewards/BAT icon, in-line tipping buttons should also be hidden. It should be considered a full opt-out. It would cause the same problem again if they went and disabled the Brave Rewards/BAT icon before going into brave://rewards Tipping settings and disabling the in-line tips. |
@Miyayes aren't they the same thing though? Both avenues lead to a fresh profile, so in theory they should emit the same results. I meant both. 🙂 Theoretically speaking they both equate to a new user, too. That being said, I'm not entirely sure if Rewards should be disabled in new profiles, if the profile they were created from has Rewards disabled. I'll leave that to the Brave team to decide. 🤷♂️ |
@resynth1943 Thanks for your comments. Just to clarify: a decision was made to have tipping buttons appear by default in Brave. It is a gateway to help new and existing users find and learn about Brave Rewards. However, the buttons should not have appeared for users who had already chosen to hide the Brave Rewards (BAT) icon in the URL bar (which is equivalent to an explicit expression of opting out). Two things to note:
Category (i) should probably have the tipping buttons hidden too. However, not sure how feasible it would be to go back and try to track those state changes. Category (ii) fall under the intentional design choice that was made to have the tip buttons appear. Category (iii) are the ones directly addressed in this issue, and the tip icons should be hidden for them and shouldn't have appeared from the beginning. It seems like a fresh profile (not new installation) might fall under (i) or (iii), but I think a fresh profile should be really just that: a fresh profile that doesn't carry over any preferences or settings from previous profiles. That would set all their settings/preferences to the defaults. And the defaults would entail tipping buttons showing by default. |
Verification passed on
Clean profile Inline tip for TwitterEnsured Inline tip icon has appeared for Twitter feeds by default when Rewards is enabled Ensured Inline tip icon has appeared for Twitter tweets by default when Rewards is enabled Ensured Inline tip icon hasn't appeared for Twitter feeds when Brave Rewards button is hidden via brave://settings/appearance Ensured Inline tip icon hasn't appeared for Twitter tweets when Brave Rewards button is hidden via brave://settings/appearance
Inline tip for RedditEnsured Inline tip icon has appeared for Reddit by default when Rewards is enabled Ensured Inline tip icon has appeared for Reddit posts by default when Rewards is enabled Ensured Inline tip icon hasn't appeared for Reddit feeds when Brave Rewards button is hidden via brave://settings/appearance Ensured Inline tip icon hasn't appeared for Reddit posts when Brave Rewards button is hidden via brave://settings/appearance
Inline tip for Github_stars tab of user profileEnsured Inline tip icon has appeared for GH stars tab of the user profile when Rewards is enabled Ensured Inline tip icon hasn't appeared for GH stars tab when Brave Rewards button is hidden via brave://settings/appearance
Inline tip for Github_commits > branch nameEnsured Inline tip icon has appeared for GH commits page when Rewards is enabled Ensured Inline tip icon hasn't appeared for GH commits page when Brave Rewards button is hidden via brave://settings/appearance
Inline tip for Github_Issues pageEnsured Inline tip icon has appeared for GH Issues page when Rewards is enabled Ensured Inline tip icon hasn't appeared for GH Issues page when Brave Rewards button is hidden via brave://settings/appearance
Inline tip for Github_PR pageEnsured Inline tip icon has appeared for GH PR page when Rewards is enabled Ensured Inline tip icon hasn't appeared for GH Issues page when Brave Rewards button is hidden via brave://settings/appearance
Inline tip for Github_Teams pageEnsured Inline tip icon has appeared for GH PR page when Rewards is enabled Ensured Inline tip icon hasn't appeared for GH Issues page when Brave Rewards button is hidden via brave://settings/appearance
Inline tip for Github_People pageEnsured Inline tip icon has appeared for GH People page when Rewards is enabled Ensured Inline tip icon hasn't appeared for GH People page when Brave Rewards button is hidden via brave://settings/appearance
Upgrade profile Hide Rewards in 1.19.88 and then upgrade to 1.20.xDo not hide Rewards in 1.19.88 upgrade to 1.20.x
Hide Rewards and Tip settings in 1.19.88 and then upgrade to 1.20.x
Verification passed on
Clean profile Inline tip for TwitterEnsured Inline tip icon has appeared for Twitter feeds by default when Rewards is enabled Ensured Inline tip icon has appeared for Twitter tweets by default when Rewards is enabled Ensured Inline tip icon hasn't appeared for Twitter feeds when Brave Rewards button is hidden via brave://settings/appearance Ensured Inline tip icon hasn't appeared for Twitter tweets when Brave Rewards button is hidden via brave://settings/appearance
Inline tip for RedditEnsured Inline tip icon has appeared for Reddit by default when Rewards is enabled Ensured Inline tip icon hasn't appeared for Reddit when Brave Rewards button is hidden via brave://settings/appearance
Inline tip for Githubstars tab of user profile Ensured Inline tip icon has appeared for GH stars tab of the user profile when Rewards is enabled Ensured Inline tip icon hasn't appeared for GH stars tab when Brave Rewards button is hidden via brave://settings/appearance commits > branch name Ensured Inline tip icon hasn't appeared for GH commits page when Brave Rewards button is hidden via brave://settings/appearance Issues page Ensured Inline tip icon hasn't appeared for GH Issues page when Brave Rewards button is hidden via brave://settings/appearance PR page Ensured Inline tip icon hasn't appeared for GH Issues page when Brave Rewards button is hidden via brave://settings/appearance Teams page Ensured Inline tip icon hasn't appeared for GH Issues page when Brave Rewards button is hidden via brave://settings/appearance People page Ensured Inline tip icon hasn't appeared for GH People page when Brave Rewards button is hidden via brave://settings/appearance Upgrade profile Hide Rewards in 1.19.88 and then upgrade to 1.20.xDo not hide Rewards in 1.19.88 upgrade to 1.20.x
Hide Rewards and Tip settings in 1.19.88 and then upgrade to 1.20.x
Verified using
Verified scenarios listed in brave/brave-core#7655 (comment) Scenario 11. Clean install 1.20.x (Beta). 2. Hid the Rewards icon via settings and restarted the browser. 3. Confirmed after restart in-line tip icons did not show on Twitter, GH, Reddit.
Scenario 2
Scenario 3
|
Description
In a recent update, in-line tipping buttons were made to appear by default in Brave. For users who had already disabled the BAT/Brave Rewards icon in their browser, in-line tip buttons should not have appeared, as those users had already expressed a desire to opt out of Brave Rewards-related features.
Additionally, disabling in-line tipping buttons for these users was made more difficult by the fact that they could not access the Brave Rewards settings page via the usual method: namely, clicking on the very BAT/Brave Rewards icon that they had already hidden.
Proposed solution
For users who have already disabled the BAT/Brave Rewards icon, roll back and hide the in-line tipping buttons.
(Any other expressions of opting out equivalent to disabling the BAT/Brave Rewards icon should also be considered.)
Related discussion
#13222
Some similar reports on Reddit.
The text was updated successfully, but these errors were encountered: