Additional failing tests for broken Boost.Test UTF command-line argument parsing. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently implemented tests are still far from a complete test suite but they do represent a good starting point for adding related tests in the future.
The bug is triggered by passing a command-line argument containing a leading space character or by passing an empty leading command-line argument with an additional argument after it. Several of the newly added tests currently only check whether the test crashes and not the command-line arguments left over after UTF processing. This is so because the current UTF implementation does not seem to handle arguments with embedded spaces correctly and that seems like a separate issue.
For every space character embedded in passed command-line arguments, except one at the beginning of the first argument and one at the end of the last argument, UTF attempts to write data into the original argv array one element passed the original array's end. That means that two such spaces cause it to write passed the extra trailing 0 element guaranteed by the ANSI C standard and thus risk undefined behaviour.
These tests fail since UTF seems to split all the received command-line arguments on any embedded spaces. This causes the arguments to be presented incorrectly to user code as well as argv buffer overruns which may cause undefined behaviour in testing applications. These changes remove the need for marking certain tests in this test module with the '<UNDESIREABLE RESULT boostorg#1>' tag. Conflicts: test/test_cla_parsing.cpp
Current UTF implementation seems to eat up trailing empty string arguments instead of passing them on to the user code test module initialization function.
|
please review local/new_cla branch and see if it address all your concerns |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is related to pull request #18, providing additional failing tests for broken Boost.Test UTF command-line argument parsing.
The tests illustrate different problems with how UTF command-line argument processing handles spaces embedded in those arguments.
Hope this helps.
Best regards,
Jurko Gospodnetić