Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not set alloc number if 1 #1

Closed
wants to merge 1 commit into from
Closed

do not set alloc number if 1 #1

wants to merge 1 commit into from

Conversation

forderud
Copy link

Please (cherry-pick) merge this change to the "master" branch, so that it becomes part of the next boost release.

As of today, boost test always overrides the allocation number to break on. This is not a good idea if the user has already set a value from the debugger.

REF: http://lists.boost.org/Archives/boost/2013/09/206204.php

@rogeeff @forderud
do not set alloc number if 1
f37bece 
[SVN r85648]

(cherry picked from commit d906a95)
jurko-gospodnetic added a commit to jurko-gospodnetic/test that referenced this pull request Oct 23, 2014
@jurko-gospodnetic
test how UTF handles spaces in command-line args
1267de8 
These tests fail since UTF seems to split all the received command-line
arguments on any embedded spaces. This causes the arguments to be presented
incorrectly to user code as well as argv buffer overruns which may cause
undefined behaviour in testing applications.

These changes remove the need for marking certain tests in this test module with
the '<UNDESIREABLE RESULT boostorg#1>' tag.

Conflicts:
	test/test_cla_parsing.cpp
raffienficiaud pushed a commit that referenced this pull request Jan 10, 2015
@ja11sop
Merge pull request #1 from jhunold/my_7397
cabc331 
Correct dependencies Boost.Timer and Boost.System
@raffienficiaud
Copy link
Member

Coming back to this: it is already in boost 1.59.

@trex58 trex58 mentioned this pull request Jan 17, 2020
Open
ecatmur added a commit to ecatmur/test that referenced this pull request Feb 15, 2021
@ecatmur
UB comparing unrelated pointers in priority_order
6f3f1bd 
Detected by asan with gcc10:

==863==ERROR: AddressSanitizer: invalid-pointer-pair: 0x7ffe21c831b0 0x00000c26f470
    #0 0x2688702 in boost::unit_test::framework::state::priority_order::operator()(boost::unit_test::test_observer*, boost::unit_test::test_observer*) const libs/test/include/boost/test/impl/framework.ipp:865
    boostorg#1 0x2688702 in std::_Rb_tree<boost::unit_test::test_observer*, boost::unit_test::test_observer*, std::_Identity<boost::unit_test::test_observer*>, boost::unit_test::framework::state::priority_order, std::allocator<boost::unit_test::test_observer*> >::_M_get_insert_unique_pos(boost::unit_test::test_observer* const&) /opt/gcc-10.2.0/include/c++/10.2.0/bits/stl_tree.h:2101
    boostorg#2 0x268aafb in std::pair<std::_Rb_tree_iterator<boost::unit_test::test_observer*>, bool> std::_Rb_tree<boost::unit_test::test_observer*, boost::unit_test::test_observer*, std::_Identity<boost::unit_test::test_observer*>, boost::unit_test::framework::state::priority_order, std::allocator<boost::unit_test::test_observer*> >::_M_insert_unique<boost::unit_test::test_observer*>(boost::unit_test::test_observer*&&) /opt/gcc-10.2.0/include/c++/10.2.0/bits/stl_tree.h:2154
    boostorg#3 0x2614ac4 in std::set<boost::unit_test::test_observer*, boost::unit_test::framework::state::priority_order, std::allocator<boost::unit_test::test_observer*> >::insert(boost::unit_test::test_observer*&&) /opt/gcc-10.2.0/include/c++/10.2.0/bits/stl_set.h:521
    boostorg#4 0x2614ac4 in boost::unit_test::framework::register_observer(boost::unit_test::test_observer&) libs/test/include/boost/test/impl/framework.ipp:1380
    boostorg#5 0x2642b56 in boost::unit_test::framework::register_observer_helper::register_obs() libs/test/include/boost/test/impl/framework.ipp:1627
    boostorg#6 0x2642b56 in boost::unit_test::framework::run(unsigned long, bool) libs/test/include/boost/test/impl/framework.ipp:1731
    boostorg#7 0x27f6c77 in boost::unit_test::unit_test_main(boost::unit_test::test_suite* (*)(int, char**), int, char**) libs/test/include/boost/test/impl/unit_test_main.ipp:250
    boostorg#8 0x27f9495 in main libs/test/include/boost/test/impl/unit_test_main.ipp:306
    boostorg#9 0x7f8d8b3c1554 in __libc_start_main ../csu/libc-start.c:266
    boostorg#10 0x568e0d  (test+0x568e0d)
@ecatmur ecatmur mentioned this pull request Feb 15, 2021
Closed
ecatmur added a commit to ecatmur/test that referenced this pull request Feb 15, 2021
@ecatmur
UB comparing unrelated pointers in priority_order
45ce5b2 
Detected by asan with gcc10:

==863==ERROR: AddressSanitizer: invalid-pointer-pair: 0x7ffe21c831b0 0x00000c26f470
    #0 0x2688702 in boost::unit_test::framework::state::priority_order::operator()(boost::unit_test::test_observer*, boost::unit_test::test_observer*) const libs/test/include/boost/test/impl/framework.ipp:865
    boostorg#1 0x2688702 in std::_Rb_tree<boost::unit_test::test_observer*, boost::unit_test::test_observer*, std::_Identity<boost::unit_test::test_observer*>, boost::unit_test::framework::state::priority_order, std::allocator<boost::unit_test::test_observer*> >::_M_get_insert_unique_pos(boost::unit_test::test_observer* const&) /opt/gcc-10.2.0/include/c++/10.2.0/bits/stl_tree.h:2101
    boostorg#2 0x268aafb in std::pair<std::_Rb_tree_iterator<boost::unit_test::test_observer*>, bool> std::_Rb_tree<boost::unit_test::test_observer*, boost::unit_test::test_observer*, std::_Identity<boost::unit_test::test_observer*>, boost::unit_test::framework::state::priority_order, std::allocator<boost::unit_test::test_observer*> >::_M_insert_unique<boost::unit_test::test_observer*>(boost::unit_test::test_observer*&&) /opt/gcc-10.2.0/include/c++/10.2.0/bits/stl_tree.h:2154
    boostorg#3 0x2614ac4 in std::set<boost::unit_test::test_observer*, boost::unit_test::framework::state::priority_order, std::allocator<boost::unit_test::test_observer*> >::insert(boost::unit_test::test_observer*&&) /opt/gcc-10.2.0/include/c++/10.2.0/bits/stl_set.h:521
    boostorg#4 0x2614ac4 in boost::unit_test::framework::register_observer(boost::unit_test::test_observer&) libs/test/include/boost/test/impl/framework.ipp:1380
    boostorg#5 0x2642b56 in boost::unit_test::framework::register_observer_helper::register_obs() libs/test/include/boost/test/impl/framework.ipp:1627
    boostorg#6 0x2642b56 in boost::unit_test::framework::run(unsigned long, bool) libs/test/include/boost/test/impl/framework.ipp:1731
    boostorg#7 0x27f6c77 in boost::unit_test::unit_test_main(boost::unit_test::test_suite* (*)(int, char**), int, char**) libs/test/include/boost/test/impl/unit_test_main.ipp:250
    boostorg#8 0x27f9495 in main libs/test/include/boost/test/impl/unit_test_main.ipp:306
    boostorg#9 0x7f8d8b3c1554 in __libc_start_main ../csu/libc-start.c:266
    boostorg#10 0x568e0d  (test+0x568e0d)

Clarify formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@forderud @raffienficiaud @rogeeff