Tests & fixes for Boost.Test UTF command-line parsing. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently implemented tests are still far from a complete test suite but they do represent a good starting point for adding related tests in the future.
The bug is triggered by passing a command-line argument containing a leading space character or by passing an empty leading command-line argument with an additional argument after it. Several of the newly added tests currently only check whether the test crashes and not the command-line arguments left over after UTF processing. This is so because the current UTF implementation does not seem to handle arguments with embedded spaces correctly and that seems like a separate issue.
|
I am completely rewriting CLA support for next release. It'll address lots of issues including these. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UTF seems to have some serious issues with its command-line parsing. :-(
This pull request adds a test module for it, and fixes one of the problems - a segfault that occurs if you attempt to pass it an argument with a leading embedded space character or an empty string as the initial but not only argument.
There are other problems with this command-line handling, but I'll add failing tests for some of them as a separate pull request based on this one.
Best regards,
Jurko Gospodnetić