prepare for releasing v0.25.0 binance.16 #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add validator remove interface * add unit test * Fix failed unit test in gov and stake * Add proposal id checking in msg validate * Add validator consensus addr into proposal decription * Add remove validator command line interface * Add new proposal type to NormalizeProposalType * add validator consensus address checking * Rename consensus address flag name * refactor handler test import * Use json marshal to replace cdc marshal * Add automatic gov proposal when proposal id is zero * add deposit flag * Add routerCallRecord * Resolve comment, a tx only contains one msg * improve the validate logic for remove validator * refactor go import * remove necessary checking
* update gov strategy * refactor * revert change
* add address for deposits * refactor * refactor * revert change * refactor * refactor * change proposals to publish * update deposit address
[R4R] stake: add feeAddr for validator
[R4R] Upgrade splitting validator address
remove all upgrade logic
* improve ValidateBasic for creating validator msg * Refactor address length checking and modify create validator cli to support gentx * Change default proposal id to -1 * Add commission validate in msg validate
…nding delegations (#102) * Add address pool to stake keep and return all completed unbonding delegations * Fix unit tests * Fix bug in getting UnbondingDelegation * Add IsDeliverTx checking * Add stake delegation address * Merge with develop and fix failed unit test
* Add cache for ante * use txHash instead of txBytes * simulate run also have cache * implement transaction simulation * Remove useless comment * Fix failed unit tests and refactor simulation * Fix bug in handle simulation context * Include signature into simulation transaction * One cache for both ante and msg handler * Add upgrade support * use runtxwith cache * Fix wrong run model * For develop, just remove old RunTx * merge getContextForAnte with cacheTxContext * Allow zero commission and fix failed units * change getContextForAnte to getContextWithCache
HaoyangLiu
approved these changes
Apr 12, 2019
ackratos
approved these changes
Apr 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added entries in
PENDING.mdwith issue #rereviewed
Files changedin the github PR explorerFor Admin Use: