[R4R] Add deposit address and do some refactor #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaoyangLiu
reviewed
Mar 29, 2019
x/gov/keeper.go
Outdated
| ParamStoreKeyDepositParams = []byte("depositparams") | ||
| ParamStoreKeyTallyParams = []byte("tallyparams") | ||
|
|
||
| DepositedCoinsAccAddr = sdk.AccAddress{0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0} |
There was a problem hiding this comment.
Is it proper to use 0x00000000000000000000 as deposit address? Cosmos uses the following method to generate address.
DepositedCoinsAccAddr = sdk.AccAddress(crypto.AddressHash([]byte("govDepositedCoins")))
BurnedDepositCoinsAccAddr = sdk.AccAddress(crypto.AddressHash([]byte("govBurnedDepositCoins")))
There was a problem hiding this comment.
yeah, it will use sha256 and get 20 bytes from it.
@darren-liu what's your point
There was a problem hiding this comment.
we never burn by chain itself.
but I think we may need a better addresses.
HaoyangLiu
approved these changes
Mar 29, 2019
ackratos
approved these changes
Mar 29, 2019
darren-liu
requested changes
Mar 29, 2019
x/gov/keeper.go
Outdated
| ParamStoreKeyDepositParams = []byte("depositparams") | ||
| ParamStoreKeyTallyParams = []byte("tallyparams") | ||
|
|
||
| DepositedCoinsAccAddr = sdk.AccAddress{0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0} |
There was a problem hiding this comment.
we never burn by chain itself.
but I think we may need a better addresses.
darren-liu
approved these changes
Mar 29, 2019
|
please make sure Erheng know this change (1. the new address in QA and Testnet 2. include all deposits amount to handle deposit/voting expire) to his recon service... |
yutianwu
pushed a commit
that referenced
this pull request
Apr 1, 2019
* R4R: Add interface to remove validator (#91) * Add validator remove interface * add unit test * Fix failed unit test in gov and stake * Add proposal id checking in msg validate * Add validator consensus addr into proposal decription * Add remove validator command line interface * Add new proposal type to NormalizeProposalType * add validator consensus address checking * Rename consensus address flag name * refactor handler test import * Use json marshal to replace cdc marshal * Add automatic gov proposal when proposal id is zero * add deposit flag * Add routerCallRecord * Resolve comment, a tx only contains one msg * improve the validate logic for remove validator * refactor go import * remove necessary checking * stake: add fee addr for each validator * [R4R] update gov strategy (#73) * update gov strategy * refactor * revert change * [R4R] Add deposit address and do some refactor (#101) * add address for deposits * refactor * refactor * revert change * refactor * refactor * change proposals to publish * update deposit address
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When ppl deposit coins to a proposal, we will add these tokens to a specific address.
And do some refactor.
Rationale
tell us why we need these changes...
Example
Add upgrade config in app.toml
Changes
Notable changes:
Preflight checks
make build)make test)make integration_test)Already reviewed by
...
Related issues
... reference related issue #'s here ...