Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R4R]: minify swagger js #92

Merged
merged 1 commit into from
Apr 8, 2019
Merged

[R4R]: minify swagger js #92

merged 1 commit into from
Apr 8, 2019

Conversation

HaoyangLiu
Copy link
Contributor

No description provided.

@yutianwu
Copy link
Contributor

can you add description

@HaoyangLiu
Copy link
Contributor Author

This is not a functional change. Now the percent of each languages in project is shown as follow:
image
javascript seems to be the main develop language which is misleading. The reason is that the swagger-ui js files are normalized and contain so many lines. We can minify them to make golang to be the main develop language.

darren-liu
darren-liu requested changes Mar 26, 2019
View reviewed changes
Copy link
Contributor

@darren-liu darren-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do not need this such invasive way to get the language corrected. Please check how cosmos/cosmos-sdk does it.

Or we do our own way as indicated at: https://github.com/github/linguist#overrides,
https://help.github.com/en/articles/about-repository-languages

@HaoyangLiu
Copy link
Contributor Author

HaoyangLiu commented Mar 26, 2019 •
edited
Loading

@darren-liu
What cosmos has done is adding gitattributes: https://github.com/cosmos/cosmos-sdk/blob/develop/.gitattributes
That's a good idea

@HaoyangLiu HaoyangLiu changed the title R4R: minify swagger js [R4R]: minify swagger js Mar 26, 2019
@ackratos ackratos self-requested a review April 4, 2019 09:13
@HaoyangLiu HaoyangLiu merged commit cd11938 into develop Apr 8, 2019
@HaoyangLiu HaoyangLiu deleted the haoyang/minify-js branch April 11, 2019 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darren-liu darren-liu darren-liu approved these changes

@ackratos ackratos ackratos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HaoyangLiu @yutianwu @ackratos @darren-liu