Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Node from parent (#5975)" #143

Closed
wants to merge 1 commit into from
Closed

Revert "Node from parent (#5975)" #143

wants to merge 1 commit into from

Conversation

blueyed
Copy link
Owner

@blueyed blueyed commented Dec 3, 2019

Ref: pytest-dev#6645

TODO:

  • keep/adjust doc/en/deprecations.rst: "construction without parent is not allowed anymore"

Old description:
This reverts commit a3c8246, reversing
changes made to 886b8d2.

Ref: pytest-dev#5975 (comment)

Conflicts:
src/_pytest/main.py
src/_pytest/unittest.py

TODO:

@blueyed blueyed closed this Dec 3, 2019
@blueyed blueyed reopened this Dec 3, 2019
@blueyed blueyed mentioned this pull request Dec 3, 2019
4 tasks
blueyed added a commit that referenced this pull request Feb 1, 2020
Ref: #142
Ref: #143

Conflicts:
	changelog/5975.deprecation.rst
	doc/en/deprecations.rst
	src/_pytest/doctest.py
	src/_pytest/nodes.py
	src/_pytest/python.py
	testing/python/collect.py
blueyed added a commit that referenced this pull request Feb 1, 2020
Ref: #142
Ref: #143

Conflicts:
	changelog/5975.deprecation.rst
	doc/en/deprecations.rst
	src/_pytest/doctest.py
	src/_pytest/nodes.py
	src/_pytest/python.py
	testing/python/collect.py
This reverts commit a3c8246, reversing
changes made to 886b8d2.

Ref: pytest-dev#5975 (comment)

Conflicts:
	src/_pytest/main.py
	src/_pytest/unittest.py

Squashed:

7c4b8a0  Revert "Node from parent (pytest-dev#5975)"
89abdb9  keep test, warning
c9062ed  warn via NodeMeta
149bddb  keep/adjust testing/test_mark.py:1013::test_addmarker_order
de91222  tests: handle DefinitionMock
9e3b17f  fix testing/test_collection.py:453::TestSession::test_parsearg

Conflicts:

    both modified:   src/_pytest/nodes.py
    both modified:   src/_pytest/python.py
@blueyed
Copy link
Owner Author

blueyed commented Feb 24, 2020

Squashed and rebased on my-master (old HEAD: c426585)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant