-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP/blocked] Factor out runner._report_for_call, using item._current_callinfo #107
base: my-master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a creative way to sort out the different interaction pattern that unit-test brings about
i hope that my fear is unwarranted (and just a remnant of past changes)
as always, naming is the most difficult
thanks for starting this POC
#: context of invocation: one of "setup", "call", | ||
#: "teardown", "memocollect" | ||
start = time() | ||
excinfo = None | ||
call = cls( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this structure changes a CallInfo
from something concrete and state-free to a state-machine tracking the progress if a call
i believe a class name change is warranted to make this clear, but off hand no good name describing it comes to mind
11bbb00
to
588d56d
Compare
588d56d
to
b1cee40
Compare
Rebase in the dark...
This reverts commit 3a7daa7.
b1cee40
to
4d578fa
Compare
Ref: pytest-dev#5996 (comment)
TODO: