Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP/blocked] Factor out runner._report_for_call, using item._current_callinfo #107

Open
wants to merge 8 commits into
base: my-master
Choose a base branch
from

Conversation

blueyed
Copy link
Owner

@blueyed blueyed commented Nov 12, 2019

Copy link

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a creative way to sort out the different interaction pattern that unit-test brings about

i hope that my fear is unwarranted (and just a remnant of past changes)

as always, naming is the most difficult

thanks for starting this POC

src/_pytest/reports.py Show resolved Hide resolved
src/_pytest/runner.py Show resolved Hide resolved
#: context of invocation: one of "setup", "call",
#: "teardown", "memocollect"
start = time()
excinfo = None
call = cls(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this structure changes a CallInfo from something concrete and state-free to a state-machine tracking the progress if a call

i believe a class name change is warranted to make this clear, but off hand no good name describing it comes to mind

@blueyed blueyed changed the title Factor out runner._report_for_call, using item._current_callinfo [WIP/blocked] Factor out runner._report_for_call, using item._current_callinfo Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants