Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Node.from_parent/.from_config indirection #6645

Closed
3 tasks
blueyed opened this issue Jan 31, 2020 · 2 comments
Closed
3 tasks

Remove Node.from_parent/.from_config indirection #6645

blueyed opened this issue Jan 31, 2020 · 2 comments
Labels
type: refactoring internal improvements to the code

Comments

@blueyed
Copy link
Contributor

blueyed commented Jan 31, 2020

This is meant to go forward with #6571 (comment) / unblock the next release.

Ref: #5975 (comment)

Proof-of-concept: blueyed#143

TODO:

@RonnyPfannschmidt
Copy link
Member

Not sure what you are doing here, this is failing the big picture at first glance and that won't do

@Zac-HD Zac-HD added the type: refactoring internal improvements to the code label Feb 1, 2020
@blueyed blueyed closed this as completed Feb 4, 2020
@blueyed
Copy link
Contributor Author

blueyed commented Feb 4, 2020

Ok, let's maybe move on then?
=> #6571 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: refactoring internal improvements to the code
Projects
None yet
Development

No branches or pull requests

3 participants