Reduce boilerplate when creating Devices #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coretl
reviewed
Apr 18, 2024
AlexanderWells-diamond
force-pushed
the
reduce_boilerplace
branch
2 times, most recently
from
7655d0b
to
6e8cf5c
Compare
coretl
reviewed
Apr 19, 2024
AlexanderWells-diamond
force-pushed
the
reduce_boilerplace
branch
from
94dff68
to
00d53af
Compare
AlexanderWells-diamond
changed the title
|
I've restored the |
This reduces the amount of duplication and repetition when adding signals to a StandardReadable. As part of this, classes defining the types of signal have been created, which control the behaviour of the Signal being registered Signals must be registered either using the "add_children_as_readables" contextmanager, or the "add_readables" function.
Review done by Tom Cobb Includes: - Much refactoring of types - Allowing wrappers to be optional - Generate hints when requested, rather than in advance
Instead of assuming everything added inside the cm is a SignalR, we will instead filter the created attributes for only those we care for. This allows us to broaden how the context manager can be used; see sim_motor for an example.
May as well test a little more code here
It will issue a DeprecationWarning when used
AlexanderWells-diamond
force-pushed
the
reduce_boilerplace
branch
from
f01dee3
to
e20915d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the amount of duplication and repetition when adding signals to a StandardReadable.
As part of this, classes defining the types of signal have been created, which control the behaviour of the Signal being registered. See
ConfigSignalandHintedSignal.Signals should now be registered either using the "add_children_as_readables" contextmanager, or the "add_readables" function.
Fixes #223
NOTE: This deprecates the
set_readable_signals()method inStandardReadable