-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardise handling of Read, Config and Hinted signals for StandardDetector #282
Comments
To summarize the meeting we just had:
@dataclass
class NDAttributePv:
name: str # name of attribute stamped on array, also scientifically useful name when appended to device.name
signal: SignalR # caget the pv given by signal.source and attach to each frame
datatype: Optional[NDAttributeDataType] = None # An override datatype, otherwise will use native EPICS type
description: str = "" # A description that appears in the HDF file as an attribute
@datackass
class NDAttributeParam:
name: str # name of attribute stamped on array, also scientifically useful name when appended to device.name
param: str # The parameter string as seen in the INP link of the record
datatype: NDAttributeDataType # The datatype of the parameter
addr: int = 0 # The address as seen in the INP link of the record
description: str = "" # A description that appears in the HDF file as an attribute
|
RE: Hints, if we add HasHints to DetectorWriter, we can propagate through to StandardDetector as well. |
Needs #314 |
After discussing this with @DiamondJoseph @ZohebShaikh @abbiemery, we decided we need per-scan behaviour, but instead of hooking prepare we will use load/save. We have tweaked the above plan to be:
To do this:
@dataclass
class NDAttributePv:
name: str # name of attribute stamped on array, also scientifically useful name when appended to device.name
signal: SignalR # caget the pv given by signal.source and attach to each frame
datatype: Optional[NDAttributeDataType] = None # An override datatype, otherwise will use native EPICS type
description: str = "" # A description that appears in the HDF file as an attribute
@datackass
class NDAttributeParam:
name: str # name of attribute stamped on array, also scientifically useful name when appended to device.name
param: str # The parameter string as seen in the INP link of the record
datatype: NDAttributeDataType # The datatype of the parameter
addr: int = 0 # The address as seen in the INP link of the record
description: str = "" # A description that appears in the HDF file as an attribute
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Extension of #223 #240, partially covered by #213
StandardDetector requires configuration in multiple ways:
acquire_time
and any number of fields on FooDriver for FooDetectorThe text was updated successfully, but these errors were encountered: