Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

282-standardise-handling-of-read-config-and-hinted-signals-for-standarddetector #468

Merged
merged 21 commits into from
Jul 26, 2024
Merged

282-standardise-handling-of-read-config-and-hinted-signals-for-standarddetector #468

merged 21 commits into from
Jul 26, 2024

Conversation

ZohebShaikh
Copy link
Contributor

No description provided.

@ZohebShaikh ZohebShaikh linked an issue Jul 18, 2024 that may be closed by this pull request
Standardise handling of Read, Config and Hinted signals for StandardDetector #282
Closed
@ZohebShaikh ZohebShaikh force-pushed the 282-standardise-handling-of-read-config-and-hinted-signals-for-standarddetector branch from 06c7a13 to b137fea Compare July 18, 2024 15:55
@ZohebShaikh ZohebShaikh changed the title initial commit 282-standardise-handling-of-read-config-and-hinted-signals-for-standarddetector Jul 22, 2024
@ZohebShaikh ZohebShaikh marked this pull request as ready for review July 22, 2024 12:09
@ZohebShaikh ZohebShaikh requested a review from coretl July 22, 2024 12:09
coretl
coretl requested changes Jul 23, 2024
View reviewed changes
src/ophyd_async/epics/areadetector/writers/hdf_writer.py Outdated Show resolved Hide resolved
src/ophyd_async/epics/areadetector/writers/hdf_writer.py Outdated Show resolved Hide resolved
src/ophyd_async/plan_stubs/nd_attributes.py Outdated Show resolved Hide resolved
src/ophyd_async/plan_stubs/nd_attributes.py Outdated Show resolved Hide resolved
coretl
coretl requested changes Jul 24, 2024
View reviewed changes
src/ophyd_async/plan_stubs/_nd_attributes.py Outdated Show resolved Hide resolved
src/ophyd_async/plan_stubs/_nd_attributes.py Outdated Show resolved Hide resolved
src/ophyd_async/plan_stubs/_nd_attributes.py Outdated Show resolved Hide resolved
@ZohebShaikh ZohebShaikh requested a review from coretl July 24, 2024 12:13
coretl
coretl requested changes Jul 25, 2024
View reviewed changes
src/ophyd_async/epics/adcore/_hdf_writer.py Outdated Show resolved Hide resolved
src/ophyd_async/epics/adcore/_hdf_writer.py Outdated Show resolved Hide resolved
src/ophyd_async/plan_stubs/_nd_attributes.py Show resolved Hide resolved
src/ophyd_async/epics/adcore/_hdf_writer.py Outdated Show resolved Hide resolved
coretl
coretl requested changes Jul 26, 2024
View reviewed changes
src/ophyd_async/epics/adcore/_hdf_writer.py Outdated Show resolved Hide resolved
src/ophyd_async/epics/adcore/_hdf_writer.py Outdated Show resolved Hide resolved
src/ophyd_async/epics/adcore/_utils.py Outdated Show resolved Hide resolved
src/ophyd_async/epics/adcore/_utils.py Outdated Show resolved Hide resolved
src/ophyd_async/epics/adcore/_utils.py Outdated Show resolved Hide resolved
src/ophyd_async/epics/adcore/_utils.py Outdated Show resolved Hide resolved
src/ophyd_async/epics/adcore/_utils.py Outdated Show resolved Hide resolved
src/ophyd_async/epics/adcore/_utils.py Outdated Show resolved Hide resolved
src/ophyd_async/plan_stubs/_nd_attributes.py Outdated Show resolved Hide resolved
@ZohebShaikh ZohebShaikh requested a review from coretl July 26, 2024 09:16
coretl
coretl requested changes Jul 26, 2024
View reviewed changes
tests/epics/adcore/test_writers.py Outdated Show resolved Hide resolved
@ZohebShaikh ZohebShaikh merged commit a794b1b into main Jul 26, 2024
18 checks passed
@ZohebShaikh ZohebShaikh deleted the 282-standardise-handling-of-read-config-and-hinted-signals-for-standarddetector branch July 26, 2024 11:26
@ZohebShaikh ZohebShaikh mentioned this pull request Jul 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coretl coretl coretl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Standardise handling of Read, Config and Hinted signals for StandardDetector
2 participants
@ZohebShaikh @coretl